Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @andrewsykim to OWNERS for cmd/cloud-controller-manager,pkg/contr… #62749

Merged
merged 1 commit into from
Apr 17, 2018
Merged

add @andrewsykim to OWNERS for cmd/cloud-controller-manager,pkg/contr… #62749

merged 1 commit into from
Apr 17, 2018

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Apr 17, 2018 •
edited
Loading

What this PR does / why we need it:
Add myself as an approver for CCM related code.

cc @wlan0

Release note:

Add @andrewsykim as an approver for CCM related code.

@k8s-ci-robot k8s-ci-robot added retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2018
@wlan0
Copy link
Member

wlan0 commented Apr 17, 2018

Well deserved @andrewsykim!

@wlan0
Copy link
Member

wlan0 commented Apr 17, 2018

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 17, 2018
@wlan0
Copy link
Member

wlan0 commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 74c6632 into kubernetes:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@thockin thockin Awaiting requested review from thockin

@wlan0 wlan0 Awaiting requested review from wlan0

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewsykim @wlan0 @k8s-ci-robot @k8s-github-robot