Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove METADATA_AGENT_VERSION config option #63000

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Remove METADATA_AGENT_VERSION config option #63000

merged 1 commit into from
Apr 24, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Apr 23, 2018

What this PR does / why we need it:
Remove METADATA_AGENT_VERSION configuration option. To keep Metadata Agent version consistent across Kubernetes deployments.

Release note:

Remove METADATA_AGENT_VERSION configuration option.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2018
@kawych
Copy link
Contributor Author

kawych commented Apr 23, 2018

/cc @piosz

@kawych
Copy link
Contributor Author

kawych commented Apr 23, 2018

/retest
/uncc @vishh

@k8s-ci-robot k8s-ci-robot removed the request for review from vishh April 23, 2018 10:54
@kawych
Copy link
Contributor Author

kawych commented Apr 23, 2018

/retest

@kawych
Copy link
Contributor Author

kawych commented Apr 24, 2018

/cc @loburm @serathius

@k8s-ci-robot
Copy link
Contributor

@kawych: GitHub didn't allow me to request PR reviews from the following users: serathius.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @loburm @serathius

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@loburm
Copy link
Contributor

loburm commented Apr 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2018
@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, loburm, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62590, 62818, 63015, 62922, 63000). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5b0df36 into kubernetes:master Apr 24, 2018
@kawych kawych mentioned this pull request Apr 25, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 25, 2018
Merge pull request #63131 from kawych/automated-cherry-pick-of-#63000…
f8473ed 
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63000: Remove METADATA_AGENT_VERSION config option

Cherry pick of #63000 on release-1.10.

#63000: Remove METADATA_AGENT_VERSION config option
@piosz
Copy link
Member

piosz commented Apr 25, 2018

/lgtm
/approve

@igorpeshansky @bmoyles0117

igorpeshansky
igorpeshansky reviewed Apr 25, 2018
View reviewed changes
cluster/gce/config-default.sh
@@ -160,9 +160,6 @@ ENABLE_METRICS_SERVER="${KUBE_ENABLE_METRICS_SERVER:-true}"
# running on the same node for exporting metrics and logs.
ENABLE_METADATA_AGENT="${KUBE_ENABLE_METADATA_AGENT:-none}"

# Version tag of metadata agent
METADATA_AGENT_VERSION="${KUBE_METADATA_AGENT_VERSION:-0.2-0.0.19-1}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the same reasoning have applied to FLUENTD_GCP_VERSION?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky left review comments

@piosz piosz Awaiting requested review from piosz

@loburm loburm Awaiting requested review from loburm

Assignees

@loburm loburm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kawych @k8s-ci-robot @loburm @MaciekPytel @k8s-github-robot @piosz @igorpeshansky