Changes kubeadm upgrade plan output & strategy #63016
Conversation
kubeadm will not guess at versions of components if it is not the same version it is guessing for. kubeadm no longer supports upgrading patch versions of previous minor versions. Signed-off-by: Chuck Ha <ha.chuck@gmail.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @chuckha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chuckha: Reiterating the mentions to trigger a notification: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chuckha Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
timothysc
removed
the
needs-ok-to-test
|
/assign @timothysc |
| fmt.Fprintf(tabw, "Kube Proxy\t%s\t%s\n", upgrade.Before.KubeVersion, upgrade.After.KubeVersion) | ||
| if features.Enabled(featureGates, features.CoreDNS) { | ||
| fmt.Fprintf(tabw, "CoreDNS\t%s\t%s\n", upgrade.Before.DNSVersion, upgrade.After.DNSVersion) | ||
| if upgrade.Before.KubeadmVersion != upgrade.After.KubeadmVersion { |
There was a problem hiding this comment.
The upgrade guides for 1.7->1.8 and 1.8->1.9 both recommend to use the latest stable version of kubeadm for upgrades, i.e. not just the exact version you’d want to upgrade to. With that in mind this check doesn’t make sense; I would expect it to check if the kubeadm version is the same or newer.
#62568 already ensures that the major and minor versions are the same.
There was a problem hiding this comment.
Good feedback, thanks.
I'll need to resolve #62568 with what I'm trying to accomplish here. Generally, I don't want past versions to tell me what versions I need to upgrade to for things like KubeDNS because old versions will tell me the wrong version numbers.
|
I need to rethink this |
kubeadm will not guess at versions of components if it is not
the same version it is guessing for.
kubeadm no longer supports upgrading patch versions of previous minor versions.
Signed-off-by: Chuck Ha ha.chuck@gmail.com
What this PR does / why we need it: This PR changes the output of kubeadm plan and encourages users to get the correct version of kubeadm for upgrading.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#739
Special notes for your reviewer:
This might require discussion or rewording. I'm ok if this doesn't go through, but we will want something like this in the not so distant future.
Release note:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews