Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dep json-iterator/go to fix base64 decode bug #63059

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Upgrade dep json-iterator/go to fix base64 decode bug #63059

merged 2 commits into from
Apr 26, 2018

Conversation

ceshihao
Copy link
Contributor

@ceshihao ceshihao commented Apr 24, 2018 •
edited
Loading

What this PR does / why we need it:
upgrade dep json-iterator/go to fix base64 decode bug #62742

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62742

Special notes for your reviewer:
Just upgrade json-iterator/go to latest which includes base64 decode fix json-iterator/go#266
No other code changes

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2018
@ceshihao
Copy link
Contributor Author

/assign @thockin

@cblecker
Copy link
Member

/assign
Please update your git version and rerun. Your older git version is causing changes to comments in Godeps.json when there shouldn’t be.

@ceshihao
Copy link
Contributor Author

@cblecker Thanks for reminder.

I have regenerated Godeps.json using a new version git.

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2018
@ceshihao
Copy link
Contributor Author

/test pull-kubernetes-verify

@cblecker
Copy link
Member

/hold
There's an issue with deps on master.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2018
@cblecker
Copy link
Member

Please run hack/update-staging-godeps.sh

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2018
@ceshihao
Copy link
Contributor Author

commit after run hack/update-staging-godeps.sh

@ceshihao
Copy link
Contributor Author

/test pull-kubernetes-integration

@cblecker
Copy link
Member

/cc @lavalamp
/sig api-machinery

Any concerns with bumping this dep, @lavalamp?

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 25, 2018
@lavalamp
Copy link
Member

I'm not super thrilled with the use of unsafe package, other than that it seems fine. I guess we already do unsafe things occasionally :(

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@cblecker
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ceshihao, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59965, 59115, 63076, 63059). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3dbcd1d into kubernetes:master Apr 26, 2018
@ceshihao ceshihao deleted the upgrade_json_package_fix_base64_newline branch April 26, 2018 01:41
@ash2k ash2k mentioned this pull request Apr 29, 2018
Closed
@caesarxuchao caesarxuchao mentioned this pull request Jun 15, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 19, 2018
Merge pull request #65157 from caesarxuchao/cherrypick-65034-1.10
32ac1c9 
Automatic merge from submit-queue.

Manually cherrypick #65034 to 1.10

Manually cherrypicking #65034. Using hack/cherry_pick_pull.sh to cherrypick is difficult because that requires cherrypicking #63059 first.

This PR imported the latest jsoniterator library so that case sensitivity during unmarhsaling is optional. The PR also set Kubernetes json serializer to be case sensitive.

Fix #64612.

```release-notes
Kubernetes json deserializer is now case-sensitive to restore compatibility with pre-1.8 servers.
If your config files contains fields with wrong case, the config files will be now invalid.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@jbeda jbeda Awaiting requested review from jbeda

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST rejects base64 data containing newlines, but PATCH accepts it
6 participants
@ceshihao @cblecker @lavalamp @k8s-ci-robot @k8s-github-robot @thockin