cloud node controller: don't override all node addresses when validating node ip from kubelet #63101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewsykim Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andrewsykim
force-pushed
the
node-controller-dont-override-node-addresses
branch
from
30b85be
to
bba31b0
Compare
…ing node ip from kubelet
andrewsykim
force-pushed
the
node-controller-dont-override-node-addresses
branch
from
bba31b0
to
bcf2356
Compare
|
/close in favour of #63170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current behaviour for node controller if a kubelet sets
--node-ipis to override all other node address types. The correct behaviour is to validate if--node-ipis set as one of the node addresses, and error if it's not.related: #61921
Special notes for your reviewer:
Release note: