New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable lease reconciler, fix shutdown race #63383

Merged
merged 3 commits into from May 4, 2018

Conversation

@liggitt
Member

liggitt commented May 3, 2018

Fixes #63378
Fixes #57617

  • Fixes the openapi script to wait for the apiserver on shutdown (like all the other scripts do)
  • Fixes the apiserver shutdown to not hang forever if the kubernetes service reconciler cannot persist to etcd
  • Readds #58474 to make the default the lease reconciler
kube-apiserver: the default `--endpoint-reconciler-type` is now `lease`. The `master-count` endpoint reconciler type is deprecated and will be removed in 1.13.

rphillips and others added some commits Jan 18, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented May 3, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented May 3, 2018

/lgtm

@rphillips

This comment has been minimized.

Member

rphillips commented May 3, 2018

lgtm!

@dims

This comment has been minimized.

Member

dims commented May 3, 2018

/lgtm

@cblecker

This comment has been minimized.

Member

cblecker commented May 3, 2018

/lgtm
/assign @sttts
for approval

@deads2k

This comment has been minimized.

Contributor

deads2k commented May 4, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, deads2k, dims, ixdy, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 4, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 4, 2018

Automatic merge from submit-queue (batch tested with PRs 63315, 63383, 63318, 63439). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 31511f9 into kubernetes:master May 4, 2018

7 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-test
Details
pull-kubernetes-bazel-test Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-typecheck Job succeeded.
Details

@liggitt liggitt deleted the liggitt:lease-reconciler branch May 4, 2018

k8s-merge-robot added a commit that referenced this pull request Jun 20, 2018

Merge pull request #63746 from redbaron/endpoint-reconciler-shutdown
Automatic merge from submit-queue.

Let the kubernetes service reconciler timeout on shutdown

Cherry-pick of shutdown fix from #63383 to 1.9 branch

Fixes the apiserver shutdown to not hang forever if the kubernetes service reconciler cannot persist to etcd

```release-note
NONE
```

/sig api-machinery

cc: @liggitt

rfranzke added a commit to gardener/gardener that referenced this pull request Jun 25, 2018

Do not use --apiserver-count flag for Shoots with Kubernetes >= 1.11
See kubernetes/kubernetes#63383, the default endpoint reconciler type is 'lease'. Only the deprecated 'master-count' reconciler type requires this flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment