New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for VM name with extra Separator String #63526

Merged
merged 1 commit into from May 8, 2018

Conversation

@djsly
Contributor

djsly commented May 8, 2018

What this PR does / why we need it:
Allows the Azure VM name to have within their name the _ character

Special notes for your reviewer:
This is the error I got before testing

May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: I0507 21:55:14.462125   39465 azure_vmss.go:108] getVmssVM gets scaleSetName ("kn-infra_ss") and instanceID ("0") for node "kn-infra000000"
May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: E0507 21:55:14.462147   39465 azure_vmss_cache.go:52] Failed to extract vmssVMName "kn-infra_ss_0"
May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: F0507 21:55:14.462160   39465 kubelet.go:1349] Kubelet failed to get node info: failed to get external ID from cloud provider: not a vmss instance

Release note:

Azure VMSS: support VM names to contain the `_` character
@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/assign @feiskyer

@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/sig azure

@k8s-ci-robot k8s-ci-robot requested review from feiskyer and jdumars May 8, 2018

@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/cherrypick-candidate

@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/milestone v1.10

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 8, 2018

@djsly: You must be a member of the kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone 1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/ok-to-test

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/retest

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/lgtm
/approve

@fejta-bot

This comment has been minimized.

fejta-bot commented May 8, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 8, 2018

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djsly, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

@feiskyer thanks for the /lgmt, are you able to set the /milestone v1.10 and the cheerypick candidate ?

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/milestone v1.10

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/kind bug
/priority important-soon

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/retest

@feiskyer

This comment has been minimized.

Member

feiskyer commented May 8, 2018

/status approved-for-milestone

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 8, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@djsly @feiskyer

Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/test pull-kubernetes-e2e-gce

1 similar comment
@djsly

This comment has been minimized.

Contributor

djsly commented May 8, 2018

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

fejta-bot commented May 8, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 8, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b00d600 into kubernetes:master May 8, 2018

15 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation djsly authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@djsly djsly deleted the djsly:fix-vmss-parsing branch May 9, 2018

k8s-merge-robot added a commit that referenced this pull request May 9, 2018

Merge pull request #63566 from djsly/automated-cherry-pick-of-#63526-…
…upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63526: adding support for VM name with extra Separator String

Cherry pick of #63526 on release-1.10.

#63526: adding support for VM name with extra Separator String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment