Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope AWS LoadBalancer security group ICMP rules to spec.loadBalancerSourceRanges #63572

Merged
merged 1 commit into from
Aug 8, 2018
Merged

scope AWS LoadBalancer security group ICMP rules to spec.loadBalancerSourceRanges #63572

merged 1 commit into from
Aug 8, 2018

Conversation

haz-mat
Copy link
Contributor

@haz-mat haz-mat commented May 9, 2018

/sig aws
What this PR does / why we need it:
Make the client CIDR ranges for MTU consistent with what the documentation appears to describe, where the ranges should be equal to spec.loadBalancerSourceRanges if supplied.

Which issue(s) this PR fixes:
Fixes #63564

Release note:

scope AWS LoadBalancer security group ICMP rules to spec.loadBalancerSourceRanges

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/aws size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2018
@wgliang
Copy link
Contributor

wgliang commented May 9, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2018
@haz-mat
Copy link
Contributor Author

haz-mat commented May 9, 2018

/assign @gnufied

@timothysc timothysc self-requested a review July 24, 2018 20:48
timothysc
timothysc approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @kubernetes/sig-aws-misc @countspongebob

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2018
@timothysc
Copy link
Member

/assign @justinsb

@nckturner
Copy link
Contributor

/lgtm

@nckturner
Copy link
Contributor

/ok-to-test

@haz-mat
Copy link
Contributor Author

haz-mat commented Aug 1, 2018

/test pull-kubernetes-e2e-gce

@timothysc
Copy link
Member

/assign @jsafrane

@haz-mat haz-mat mentioned this pull request Aug 7, 2018
Closed
@timothysc
Copy link
Member

/test pull-kubernetes-integration

@d-nishi
Copy link

d-nishi commented Aug 8, 2018 •
edited
Loading

/lgtm - lets merge this.

@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: d-nishi, haz-mat, nckturner, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fc89a80 into kubernetes:master Aug 8, 2018
@yagonobre yagonobre mentioned this pull request Jan 18, 2019
Closed
@danitfk
Copy link

danitfk commented Jan 27, 2020 •
edited
Loading

@haz-mat
Hey Matthew,
Do you think is there any way to disable this feature to not adding a separated rule for ICMP?
because of limitations about rules per security, I want to delete ICMP rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

@countspongebob countspongebob Awaiting requested review from countspongebob

Assignees

@gnufied gnufied

@justinsb justinsb

@timothysc timothysc

@nckturner nckturner

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS cloudprovider: MTU discovery security group rule cannot be scoped. Hardcoded to 0.0.0.0/0