New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual cherrypick of kube-openapi changes for release-1.9 #63626
Manual cherrypick of kube-openapi changes for release-1.9 #63626
Conversation
bump Godep against kube-openapi/release-1.9 branch
/lgtm /approval |
Why is this manual an not an automated CP of something already in master? |
/approve I'll assume there's a good reason for this and approve so I don't hold up the works :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, mbohlool, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because it's a CP of changes in vendor directory. We don't want to bump the Godep version in this release branch to be the same as master, which would include every change in kube-openapi up-to-date. Instead we create a new branch in kube-openapi (https://github.com/kubernetes/kube-openapi/tree/release-1.9) which only include the two commits we need, and CP that Godep version. |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Thanks Haowei, that makes sense. :)
…On Thu, May 10, 2018 at 2:12 AM Kubernetes Submit Queue < ***@***.***> wrote:
Merged #63626 <#63626>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63626 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnglpCsw6F-TtEcXP86yw9QNleqTTFXks5txASNgaJpZM4T5HLX>
.
|
What this PR does / why we need it:
Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67
Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty
Paths
/Definitions
)Release note:
/cc @mbohlool
/sig api-machinery