-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use subtest for table units (pkg-scheduler-algorithm-priorities-util) #63659
use subtest for table units (pkg-scheduler-algorithm-priorities-util) #63659
Conversation
@@ -66,8 +66,10 @@ func TestGetNonzeroRequests(t *testing.T) { | |||
} | |||
|
|||
for _, td := range tds { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: could you change td and tds to test and tests to be consistent with the rest of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/ok-to-test |
46b2e5d
to
a06b800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-kubernetes-e2e-kops-aws |
/test pull-kubernetes-e2e-gce |
5 similar comments
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-e2e-gce |
employ consitent table var naming - kubernetes#63659 (comment)
a06b800
to
d1abc5c
Compare
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks, @xchapter7x!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, misterikkit, xchapter7x The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
Automatic merge from submit-queue (batch tested with PRs 65230, 57355, 59174, 63698, 63659). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it: Update scheduler's unit table tests to use subtest
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
breaks up PR: #63281
/ref #63267
Release note: