New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExtraArgs kubeadm preflight check #63673

Merged
merged 1 commit into from May 11, 2018

Conversation

@chuckha
Member

chuckha commented May 10, 2018

This check pulled in a number of dependencies that bloated the dep graph.

The feature itself was not worth an extra 500 dependencies so we decided
to remove the feature.

Closes kubernetes/kubeadm#497

Signed-off-by: Chuck Ha ha.chuck@gmail.com

What this PR does / why we need it:
This PR removes a check that was pulling in a lot of external dependencies. We decided the check was not worth the extra dependencies.

Special notes for your reviewer:
We might want to keep the first part of the check and only delete the second part, but it was easier to delete the whole thing.

Release note:

Removes a preflight check for kubeadm that validated custom kube-apiserver, kube-controller-manager and kube-scheduler arguments.
Remove ExtraArgs kubeadm preflight check
This check pulled in a number of dpendencies that bloated the dep graph.

The feature itself was not worth an extra 500 dependencies so we decided
to remove the feature.

Closes kubernetes/kubeadm#497

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>
@dims

This comment has been minimized.

Member

dims commented May 10, 2018

i was trying luxas' suggestion out and ended up with this exact change :) LGTM 👍

@dims

This comment has been minimized.

Member

dims commented May 10, 2018

we'll need a release note as we are dropping some user facing functionality

@dims

This comment has been minimized.

Member

dims commented May 10, 2018

/ok-to-test

@kad

This comment has been minimized.

Member

kad commented May 10, 2018

@chuckha fix the test failures, otherwise lgtm.

@chuckha

This comment has been minimized.

Member

chuckha commented May 10, 2018

/test pull-kubernetes-integration

@chuckha

This comment has been minimized.

Member

chuckha commented May 10, 2018

/test pull-kubernetes-verify

@chuckha

This comment has been minimized.

Member

chuckha commented May 10, 2018

/test pull-kubernetes-integration

@chuckha

This comment has been minimized.

Member

chuckha commented May 10, 2018

/test pull-kubernetes-verify

@kad

This comment has been minimized.

Member

kad commented May 10, 2018

/lgtm

@dims

This comment has been minimized.

Member

dims commented May 10, 2018

/assign @luxas
/assign @timothysc

Tim, Lucas, this is ready!

/lgtm

@timothysc

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, dims, kad, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 11, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@timothysc

This comment has been minimized.

Member

timothysc commented May 11, 2018

/test pull-kubernetes-integration

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 11, 2018

Automatic merge from submit-queue (batch tested with PRs 63673, 63712). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 6f182a1 into kubernetes:master May 11, 2018

14 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-integration
Details
pull-kubernetes-integration Job triggered.
Details
cla/linuxfoundation chuckha authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@luxas

This comment has been minimized.

Member

luxas commented May 11, 2018

Thanks @chuckha! This LGTM as well 👍

k8s-merge-robot added a commit that referenced this pull request May 12, 2018

Merge pull request #63743 from liggitt/e2e-auth-plugins
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

register client-go auth plugins for e2e

e2e depends on use of the gcp client-go auth provider, but did not explicitly register the auth provider. it indirectly imported the plugins via a roundabout chain (see #63731 (comment)) which broke when those imports were trimmed in #63673

if e2e requires these auth plugins, it should include them explicitly in the top-level test package

fixes #63731

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment