Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #63170: Report node DNS info with --node-ip #63737

Merged
merged 1 commit into from Aug 1, 2018
Merged

Automated cherry pick of #63170: Report node DNS info with --node-ip #63737

merged 1 commit into from Aug 1, 2018

Conversation

micahhausler
Copy link
Member

Cherry pick of #63170 on release-1.10.

#63170: Report node DNS info with --node-ip

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 11, 2018
@micahhausler
Report node DNS info with --node-ip
be5c132 
```release-note
Report node DNS info with --node-ip flag
```
@micahhausler micahhausler force-pushed the automated-cherry-pick-of-#63170-upstream-release-1.10 branch from 8f0a146 to be5c132 Compare May 11, 2018 23:29
@micahhausler
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@micahhausler
Copy link
Member Author

/assign @dchen1107

@andrewsykim
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2018
@micahhausler
Copy link
Member Author

/test pull-kubernetes-bazel-test
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-kubemark-e2e-gce

@micahhausler
Copy link
Member Author

/test pull-kubernetes-bazel-test
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@tallclair tallclair removed their request for review June 21, 2018 00:10
@andrewsykim
Copy link
Member

/test pull-kubernetes-e2e-kops-aws

@micahhausler
Copy link
Member Author

@dchen1107 Can this get into the 1.10 branch?

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 27, 2018
@MaciekPytel
Copy link
Contributor

This still needs an approval. @dchen1107 Can you take a look and approve or assign a different approver?

@dchen1107
Copy link
Member

/re-test

@dchen1107
Copy link
Member

/approve

I approved the pr but please fix the failing tests. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, dchen1107, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@micahhausler
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@micahhausler
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 6287149 into kubernetes:release-1.10 Aug 1, 2018
@micahhausler micahhausler deleted the automated-cherry-pick-of-#63170-upstream-release-1.10 branch January 21, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas Awaiting requested review from luxas

Assignees

@dchen1107 dchen1107

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@micahhausler @andrewsykim @MaciekPytel @dchen1107 @k8s-ci-robot @fejta-bot @k8s-github-robot