Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Remove .AuthorizationModes in the v1alpha2 API #64068

Merged
merged 3 commits into from
May 22, 2018

Conversation

luxas
Copy link
Member

@luxas luxas commented May 19, 2018

What this PR does / why we need it:
Now that we have #63879, we don't actually need to have :AuthorizationModes in our API anymore. This PR removes support for .AuthorizationModes in the v1alpha2 API, but keeps an upgrade path available (automatic conversion) from the v1alpha1 version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of kubernetes/community#2131

Special notes for your reviewer:
Depends on:

Release note:

[action required] kubeadm: Support for `.AuthorizationModes` in the kubeadm v1alpha2 API has been removed. Instead, you can use the `.APIServerExtraArgs` and `.APIServerExtraVolumes` fields to achieve the same effect. Files using the v1alpha1 API and setting this field will be automatically upgraded to this v1alpha2 API and the information will be preserved.

@kubernetes/sig-cluster-lifecycle-pr-reviews @liztio

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 19, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 19, 2018
@luxas luxas force-pushed the kubeadm_remove_authzmodes branch from c3373d2 to 687fe22 Compare May 21, 2018 05:50
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 21, 2018
@luxas
Copy link
Member Author

luxas commented May 21, 2018

rebased upon #63879 and #63917 👍

@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

5 similar comments
@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

@luxas
Copy link
Member Author

luxas commented May 21, 2018

/retest

@neolit123
Copy link
Member

this page has a v1alpha1 example:
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/#config-file

should it be updated to v1alpha2 for 1.11?

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liztio - we're going to need to doc the args feedback loop, b/c I can guarantee there will be feedback.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,78 +0,0 @@
api:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change seems unrelated?

Copy link
Member Author

@luxas luxas May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 4f0020d, I had to remove it as I realized kubeadm v1.11 won't be able to marshal the v1alpha1 API, only the newer v1alpha2 (this due to that conversions only work one way: from v1alpha1 to v1alpha2(==internal), not the other way round).
Hence I had to remove the e2e unit tests that printed v1alpha1 versions as they won't work.
Makes sense?

@luxas
Copy link
Member Author

luxas commented May 21, 2018

we're going to need to doc the args feedback loop, b/c I can guarantee there will be feedback.

Yup. I also filed kubernetes/kubeadm#842 so we can take advantage of the godoc comments as much as possible initially, and then write custom docs on top, instead of just the limited amount of manually created content we have right now. As we grow more confident in our API we can also start documenting it more clearly and visibly.

/retest

@luxas
Copy link
Member Author

luxas commented May 21, 2018

should it be updated to v1alpha2 for 1.11?

@neolit123 yes, but we'd like to have automatically-generated content as a base, and add custom API docs on top.

@neolit123
Copy link
Member

yes, but we'd like to have automatically-generated content as a base, and add custom API docs on top.

i understand,
that config example is not generated, so it has to be edited manually each time the API changes.
i'm not sure what tooling will generate such an example config that also dumps the types:
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/#config-file

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63151, 63795, 63553, 64068, 64113). If you want to cherry-pick this change to another branch, please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants