-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Remove .AuthorizationModes in the v1alpha2 API #64068
kubeadm: Remove .AuthorizationModes in the v1alpha2 API #64068
Conversation
c3373d2
to
687fe22
Compare
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
this page has a should it be updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@liztio - we're going to need to doc the args feedback loop, b/c I can guarantee there will be feedback.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luxas, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,78 +0,0 @@ | |||
api: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 4f0020d, I had to remove it as I realized kubeadm v1.11 won't be able to marshal the v1alpha1 API, only the newer v1alpha2 (this due to that conversions only work one way: from v1alpha1 to v1alpha2(==internal), not the other way round).
Hence I had to remove the e2e unit tests that printed v1alpha1 versions as they won't work.
Makes sense?
Yup. I also filed kubernetes/kubeadm#842 so we can take advantage of the godoc comments as much as possible initially, and then write custom docs on top, instead of just the limited amount of manually created content we have right now. As we grow more confident in our API we can also start documenting it more clearly and visibly. /retest |
@neolit123 yes, but we'd like to have automatically-generated content as a base, and add custom API docs on top. |
i understand, |
Automatic merge from submit-queue (batch tested with PRs 63151, 63795, 63553, 64068, 64113). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Now that we have #63879, we don't actually need to have
:AuthorizationModes
in our API anymore. This PR removes support for.AuthorizationModes
in the v1alpha2 API, but keeps an upgrade path available (automatic conversion) from the v1alpha1 version.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of kubernetes/community#2131
Special notes for your reviewer:
Depends on:
.AuthorizationModes
and.APIServerExtraArgs
#63879Release note:
@kubernetes/sig-cluster-lifecycle-pr-reviews @liztio