Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly identify types served in the kube-apiserver openapi doc #64174

Merged
merged 1 commit into from
May 24, 2018
Merged

Correctly identify types served in the kube-apiserver openapi doc #64174

merged 1 commit into from
May 24, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 23, 2018 •
edited
Loading

Fixes #52741

Split out from #63893

The kube-apiserver openapi doc now includes extensions identifying APIService and CustomResourceDefinition kinds

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 23, 2018
@liggitt
Copy link
Member Author

liggitt commented May 23, 2018

cc @kubernetes/sig-api-machinery-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 23, 2018
@liggitt liggitt mentioned this pull request May 23, 2018
Merged
@liggitt liggitt force-pushed the correct-openapi-extensions branch from 4de8ecd to 4d28024 Compare May 23, 2018 00:32
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2018
@liggitt liggitt force-pushed the correct-openapi-extensions branch from 4d28024 to 43551e8 Compare May 23, 2018 01:00
@liggitt
Copy link
Member Author

liggitt commented May 23, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented May 23, 2018

/test pull-kubernetes-kubemark-e2e-gce

@jennybuckley
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2018
@lavalamp
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2018
@jennybuckley
Copy link

/test pull-kubernetes-e2e-gce-100-performance

@jennybuckley
Copy link

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64174, 64187, 64216, 63265, 64223). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fa354b3 into kubernetes:master May 24, 2018
@liggitt liggitt deleted the correct-openapi-extensions branch May 29, 2018 13:16
@nikhita nikhita mentioned this pull request Jun 1, 2018
Closed
@liggitt liggitt mentioned this pull request Jun 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaoShuFeng CaoShuFeng Awaiting requested review from CaoShuFeng

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@lavalamp lavalamp

@jennybuckley jennybuckley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @jennybuckley @lavalamp @k8s-ci-robot @fejta-bot @k8s-github-robot