Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly identify types served in the kube-apiserver openapi doc #64174

Merged
merged 1 commit into from May 24, 2018

Conversation

@liggitt
Copy link
Member

liggitt commented May 23, 2018

Fixes #52741

Split out from #63893

The kube-apiserver openapi doc now includes extensions identifying APIService and CustomResourceDefinition kinds
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 23, 2018

@liggitt liggitt force-pushed the liggitt:correct-openapi-extensions branch from 4de8ecd to 4d28024 May 23, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels May 23, 2018

@liggitt liggitt force-pushed the liggitt:correct-openapi-extensions branch from 4d28024 to 43551e8 May 23, 2018

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 23, 2018

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 23, 2018

/test pull-kubernetes-kubemark-e2e-gce

@jennybuckley

This comment has been minimized.

Copy link
Contributor

jennybuckley commented May 23, 2018

/lgtm

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented May 23, 2018

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jennybuckley

This comment has been minimized.

Copy link
Contributor

jennybuckley commented May 23, 2018

/test pull-kubernetes-e2e-gce-100-performance

@jennybuckley

This comment has been minimized.

Copy link
Contributor

jennybuckley commented May 24, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented May 24, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 24, 2018

Automatic merge from submit-queue (batch tested with PRs 64174, 64187, 64216, 63265, 64223). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fa354b3 into kubernetes:master May 24, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.