Fix nodeport repair for ESIPP services

[nicksardo]

What this PR does / why we need it:
The nodeport allocation repair controller does not scrape the Service.Spec.healthCheckNodePort value and would remove the allocation from memory and etcd after 10 minutes. This opens the door for other services to use the same nodeport and cause collisions.

Which issue(s) this PR fixes:
Fixes #54885
Similar to #64349

Release note:

Fix issue of colliding nodePorts when the cluster has services with externalTrafficPolicy=Local

[k8s-github-robot]

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

[nicksardo]

/assign wojtek-t

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nicksardo]

/retest

[MrHohn]

What about modifying the existing method?

kubernetes/pkg/registry/core/service/rest.go

Lines 511 to 520 in 397e661

	func CollectServiceNodePorts(service *api.Service) []int {
	servicePorts := []int{}
	for i := range service.Spec.Ports {
	servicePort := &service.Spec.Ports[i]
	if servicePort.NodePort != 0 {
	servicePorts = append(servicePorts, int(servicePort.NodePort))
	}
	}
	return servicePorts
	}

[nicksardo]

The existing func is used in numerous places which expect it to only handle the port nodeports - not the healthcheck nodeport.

[MrHohn]

I see, thanks for clarifying.

[MrHohn]

/lgtm

[MrHohn]

I see, thanks for clarifying.

[MrHohn]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrHohn, nicksardo
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wojtek-t

Assign the PR to them by writing /assign @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/registry/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@nicksardo: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-typecheck	2a3c545f34f90739682b8b27aa4d7d6fc28e8aa9	link	/test pull-kubernetes-typecheck
pull-kubernetes-e2e-gce-100-performance	2a3c545f34f90739682b8b27aa4d7d6fc28e8aa9	link	/test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-local-e2e	2a3c545f34f90739682b8b27aa4d7d6fc28e8aa9	link	/test pull-kubernetes-local-e2e
pull-kubernetes-node-e2e	82f63ea	link	/test pull-kubernetes-node-e2e
pull-kubernetes-verify	82f63ea	link	/test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.