-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rbd device works at block mode not get mapped to container #64555
fix rbd device works at block mode not get mapped to container #64555
Conversation
/ok-to-test |
@wenlxie Please add unit test case for it. You'd better submit one detail issue about it. |
/skip |
/assign @rootfs |
/uncc |
…n docker restart 2. Add unit test case for rbd
/test pull-kubernetes-e2e-kops-aws |
@wgliang Test had all passed |
/lgtm |
@dims Can you have the look? |
@kubernetes/sig-storage-pr-reviews |
/sig storage |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, wenlxie, wgliang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue (batch tested with PRs 65254, 64837, 64782, 64555, 64850). If you want to cherry-pick this change to another branch, please follow the instructions here. |
In my environment, restart docker will caused all of the container restart(our kernel is a bit old).
Kubelet will also be restart.
After the container up , I checked the container and find the RBD block device is not mapped to container.
When I inspect the container, its {HostConfig.Devices[]} field is empty.
I did some debug, then find that at code https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_pods.go#L113
The volName is empty.