Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rbd device works at block mode not get mapped to container #64555

Merged
merged 1 commit into from
Jun 20, 2018
Merged

fix rbd device works at block mode not get mapped to container #64555

merged 1 commit into from
Jun 20, 2018

Conversation

wenlxie
Copy link
Contributor

@wenlxie wenlxie commented May 31, 2018

In my environment, restart docker will caused all of the container restart(our kernel is a bit old).
Kubelet will also be restart.
After the container up , I checked the container and find the RBD block device is not mapped to container.
When I inspect the container, its {HostConfig.Devices[]} field is empty.
I did some debug, then find that at code https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_pods.go#L113
The volName is empty.

Fix issues for block device not mapped to container.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2018
@wenlxie
Copy link
Contributor Author

wenlxie commented May 31, 2018

@mkimuram @mtanino @sbezverk @wgliang PTAL

@wgliang
Copy link
Contributor

wgliang commented May 31, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2018
@wgliang
Copy link
Contributor

wgliang commented May 31, 2018

@wenlxie Please add unit test case for it. You'd better submit one detail issue about it.

@mkimuram
Copy link
Contributor

I confirmed that it's the similar fix discussed for Azure in #63841 and fixed in the same way as below commit(541edb7)

@wgliang
Copy link
Contributor

wgliang commented May 31, 2018

/skip

@wgliang
Copy link
Contributor

wgliang commented May 31, 2018

/assign @rootfs

@sjenning
Copy link
Contributor

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from sjenning May 31, 2018 20:22
…n docker restart

2. Add unit test case for rbd
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2018
@wenlxie
Copy link
Contributor Author

wenlxie commented Jun 5, 2018

UT case had been added
@wgliang @rootfs PTAL

@wgliang
Copy link
Contributor

wgliang commented Jun 5, 2018

/test pull-kubernetes-e2e-kops-aws

@wenlxie
Copy link
Contributor Author

wenlxie commented Jun 7, 2018

@wgliang Test had all passed

@wgliang
Copy link
Contributor

wgliang commented Jun 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2018
@wenlxie
Copy link
Contributor Author

wenlxie commented Jun 15, 2018

@dims Can you have the look?
It is pending for a long time
Thanks

@dims
Copy link
Member

dims commented Jun 15, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 15, 2018
@dims
Copy link
Member

dims commented Jun 15, 2018

/sig storage

@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, wenlxie, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65254, 64837, 64782, 64555, 64850). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1bdee56 into kubernetes:master Jun 20, 2018
@wenlxie wenlxie deleted the upstream.master.fixrbdblockmode branch October 24, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants