Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic while provisioning Azure security group rules #64739

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Jun 5, 2018

What this PR does / why we need it:

kube-controller-manager panic when provisioning Azure security group rules, especially when securityGroupName is wrong configured. This PR fixes the issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64716

Special notes for your reviewer:

Should also cherry pick to release-1.10.

Release note:

Fix kube-controller-manager panic while provisioning Azure security group rules

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Jun 5, 2018

/sig azure
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/azure kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 5, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Jun 5, 2018

Added to v1.11 milestone since this is a bug fix.

/status approved-for-milestone
/milestone v1.11

@seanknox
Copy link

seanknox commented Jun 5, 2018

LGTM. Thanks @feiskyer !

@feiskyer
Copy link
Member Author

feiskyer commented Jun 5, 2018

/retest

@dims
Copy link
Member

dims commented Jun 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@dims @feiskyer

Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit def5179 into kubernetes:master Jun 5, 2018
@feiskyer feiskyer deleted the az-nsg branch June 6, 2018 02:08
k8s-github-robot pushed a commit that referenced this pull request Jun 11, 2018
…39-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64739: Fix panic while provisioning Azure security group rules

Cherry pick of #64739 on release-1.10.

#64739: Fix panic while provisioning Azure security group rules
k8s-github-robot pushed a commit that referenced this pull request Jun 20, 2018
…39-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #64739: Fix panic while provisioning Azure security group rules

Cherry pick of #64739 on release-1.9.

#64739: Fix panic while provisioning Azure security group rules
@feiskyer feiskyer restored the az-nsg branch July 20, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.10.3 kube-controller-manager crashes after Azure provisioning load balancer
5 participants