-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Update the dropin for the kubelet in v1.11 #64780
Conversation
/kind feature |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process Pull Request Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
in the future I think we should de-dupe this
/cc @chuckha
I think so too if possible, but there is one small difference I don't know if can be customized easily, |
build-vars through bazel gen. |
Ugh, apparently there is no OWNERS file for /test pull-kubernetes-e2e-kubeadm-gce |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: luxas, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,13 +1,11 @@ | |||
# Note: This dropin only works with kubeadm and kubelet v1.11+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon my ignorance here, but how will this work during upgrades? Once the kubeadm deb is installed the kubelet service will be restarted and pick up this drop in file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade will overwrite but drop and env-override on join that the operator will need to address.
upgrades are not seamless which is why @luxas did this PR with it's own action required release note.
/retest Review the full test history for this PR. Silence the bot with an |
Automatic merge from submit-queue (batch tested with PRs 64009, 64780, 64354, 64727, 63650). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Automatic merge from submit-queue (batch tested with PRs 63386, 64624, 62297, 64847). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Final kubeadm-kubelet integration refactor PR **What this PR does / why we need it**: Note: Work in progress This PR: - [x] Updates the debs/rpms to do the "right thing" with the new integration flow - Broken out into #64780 - [x] Uploads the `CRISocket` information to the Node object as an annotation - Broken out into: #64792 - [x] Makes the `kubeadm init` / `kubeadm join` flow to be preflight, stop kubelet, write config/env files, daemon-reload, start kubelet - [x] Renames `.NodeRegistration.ExtraArgs` to `.NodeRegistration.KubeletExtraArgs` as discussed in the SIG meeting - [x] Adds a `kubeadm upgrade node config` command for fetching the latest configuration and writing it down to the node before upgrading the kubelet - [x] Makes dynamic kubelet config actually get enabled when the feature gate in kubeadm is specifically opted into by the user - [x] Fixes misc. minor bugs - [x] Makes sure `kubeadm init --dry-run` works, so the dry-run functionality works for the kubelet integration as well **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note kubeadm: Add a new `kubeadm upgrade node config` command ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
What this PR does / why we need it:
One of the final pieces of kubernetes/kubeadm#851, kubernetes/kubeadm#847 and kubernetes/kubeadm#822
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):(partially)
Fixes kubernetes/kubeadm#822
Special notes for your reviewer: Please check whether this release note makes sense to you.
Release note:
@kubernetes/sig-cluster-lifecycle-pr-reviews