Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #63650: Never clean backoff in job controller #64811

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Jun 6, 2018

Cherry pick of #63650 on release-1.10.

#63650: Never clean backoff in job controller

@k8s-ci-robot
Copy link
Contributor

@cblecker: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #63650.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@cblecker: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2018
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cblecker
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: janetkuo

Assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member Author

cblecker commented Jun 6, 2018

/sig apps
/milestone v1.10
/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 6, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jun 6, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 6, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Approval

@MaciekPytel @cblecker @janetkuo @soltysh @kubernetes/sig-apps-misc

Action required: This pull request must have the status/approved-for-milestone label applied by a SIG maintainer.

Pull Request Labels
  • sig/apps: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@cblecker cblecker closed this Jun 6, 2018
@cblecker cblecker deleted the automated-cherry-pick-of-#63650-upstream-release-1.10 branch June 6, 2018 05:57
@k8s-ci-robot
Copy link
Contributor

@cblecker: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-build 1d247c7 link /test pull-kubernetes-bazel-build
pull-kubernetes-e2e-gce-device-plugin-gpu 1d247c7 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-e2e-gce 1d247c7 link /test pull-kubernetes-e2e-gce
pull-kubernetes-typecheck 1d247c7 link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-kops-aws 1d247c7 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-integration 1d247c7 link /test pull-kubernetes-integration
pull-kubernetes-bazel-test 1d247c7 link /test pull-kubernetes-bazel-test
pull-kubernetes-kubemark-e2e-gce-big 1d247c7 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-kubemark-e2e-gce 1d247c7 link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-verify 1d247c7 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. milestone/needs-approval priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants