go_install_from_commit: copy vendored dependencies into GOPATH #64928
Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/S
| # As a hacky workaround, copy the dependencies from tip into GOPATH. | ||
| ( | ||
| cd "${KUBE_TEMP}/go/src/${pkg}" | ||
| while [[ "$(pwd)" != "${KUBE_TEMP}/go/src" && "$(pwd)" != "/" ]]; do |
There was a problem hiding this comment.
I know temp directories on macOS are weird, so I'd appreciate someone with a Mac testing to make sure this works correctly.
There was a problem hiding this comment.
held to test #64929 (comment) instead, running a few things to sanity check on mac
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
|
This PR is not for the master branch but does not have the |
|
/hold The cherrypick PR #64929 is probably a better fix. |
k8s-ci-robot
added
the
do-not-merge/hold
|
@ixdy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close in favor of #64929 |
…57600-#62499-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #61575: Remove all upstream BUILD, BUILD.bazel, and WORKSPACE #57600: Vendor gazelle #62499: Update kazel to include openapi tag detection fix Cherry pick of #61575 #57600 #62499 on release-1.10. #61575: Remove all upstream BUILD, BUILD.bazel, and WORKSPACE #57600: Vendor gazelle #62499: Update kazel to include openapi tag detection fix This is an alternative to #64928, and would fix #64925. We can't just cherry-pick #57600, since there was a prerequisite PR and a fixup PR afterwards.
What this PR does / why we need it:
go_install_from_commitis an abomination and I regret ever having written it.gazelle recently vendored
golang.org/x/tools/go/vcs(bazelbuild/bazel-gazelle#228).As a result,
go get -d github.com/bazelbuild/bazel-gazelle/cmd/gazelleno longer installsgolang.org/x/tools/go/vcsinto the GOPATH, and so when we check out the older commit ofgazelleto install, this dependency is missing.This PR adds another level of hackery by copying any
vendor/directory in the package path into the GOPATH before checking out the requested commit. This theoretically future-proofs us from similar breakages in the future, and using an arbitrary version of these dependencies from thevendor/directory is no worse thango get -ddownloading the dependencies from tip.Cherry-picking #57600 is the better fix, but it's also more involved.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #64925
/assign @cblecker @BenTheElder