Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add "MayRunAs" value among other GroupStrategies #65135
What this PR does / why we need it:
This new strategy works similarly to the "MustRunAs" one, except that
Which issue(s) this PR fixes
changed the title from
[WIP] Add "MayRunAs" value among other GroupStrategies
Add "MayRunAs" value among other GroupStrategies
Jun 18, 2018
This change introduces backward incompatibility since the "MayRunAs" value to the groups is unknown to previous API versions. If we convert this to "MustRunAs" internally, we wouldn't be able to later get the information that it's actually "MayRunAs".
This change introduces backward incompatibility since the "MayRunAs" value to the groups is unknown to previous API versions.
Backwards incompatibility means that a resource that was valid in a previous version is no longer valid (or behaves differently), which isn't the case here. What you're refering to is forwards compatibility, and that's not something Kubernetes provides, so this is a non-issue.
Thank you @tallclair for your comments, my apologies that it took me so long to react in the PR accordingly.
A few nits, and please fix the test. Everything else lgtm.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here