Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crictl to v1.11.0. #65254

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Update crictl to v1.11.0. #65254

merged 1 commit into from
Jun 20, 2018

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jun 20, 2018 •
edited
Loading

Update crictl to newly released v1.11.0 version on GCE. See https://github.com/kubernetes-incubator/cri-tools/releases/tag/v1.11.0

Release note:

Update crictl on GCE to v1.11.0.

@kubernetes/sig-node-pr-reviews @feiskyer @yujuhong @dchen1107

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2018
@Random-Liu Random-Liu added this to the v1.11 milestone Jun 20, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2018
@Random-Liu Random-Liu added cherrypick-candidate kind/feature Categorizes issue or PR as related to a new feature. labels Jun 20, 2018
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@feiskyer
Copy link
Member

/lgtm

@dims
Copy link
Member

dims commented Jun 20, 2018

/sig gcp
/assign @mwielgus

@dims
Copy link
Member

dims commented Jun 20, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member

dims commented Jun 20, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 20, 2018
@dims
Copy link
Member

dims commented Jun 20, 2018

/assign @MaciekPytel

@dims
Copy link
Member

dims commented Jun 20, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@MaciekPytel @Random-Liu @feiskyer @mwielgus @yujuhong

Pull Request Labels
  • sig/gcp sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/feature: New functionality.
Help

@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MaciekPytel, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2018
@jberkus
Copy link

jberkus commented Jun 20, 2018 •
edited
Loading

Can we put a release note in anyway? Noting the version change will help folks off GCE using CRI-O know to upgrade to the new release version.

@dims dims mentioned this pull request Jun 20, 2018
Merged
@dims
Copy link
Member

dims commented Jun 20, 2018

@Random-Liu i've filed a cherry pick for you. Can you please add a release note for this please?

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 20, 2018
@Random-Liu
Copy link
Member Author

Can we put a release note in anyway? Noting the version change will help folks off GCE using CRI-O know to upgrade to the new release version.

@jberkus Done.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2018 •
edited
Loading

@Random-Liu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce e862da1 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65254, 64837, 64782, 64555, 64850). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f5763a9 into kubernetes:master Jun 20, 2018
k8s-github-robot pushed a commit that referenced this pull request Jun 20, 2018
Merge pull request #65273 from dims/automated-cherry-pick-of-#65254-u…
54d1e98 
…pstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65254: Update crictl to v1.11.0.

Cherry pick of #65254 on release-1.11.

#65254: Update crictl to v1.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

Assignees

@feiskyer feiskyer

@MaciekPytel MaciekPytel

@yujuhong yujuhong

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Random-Liu @yujuhong @feiskyer @dims @k8s-github-robot @MaciekPytel @k8s-ci-robot @jberkus @mwielgus