Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add volume mode field to constructed volume spec for CSI plugin #65456

Merged
merged 1 commit into from
Jul 9, 2018
Merged

add volume mode field to constructed volume spec for CSI plugin #65456

merged 1 commit into from
Jul 9, 2018

Conversation

wenlxie
Copy link
Contributor

@wenlxie wenlxie commented Jun 26, 2018

Add volume mode filed to constructed Volume Spec for CSI plugin

Add volume mode filed to constructed volume spec for CSI plugin

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2018
@wenlxie
Copy link
Contributor Author

wenlxie commented Jun 26, 2018

@msau42

@wenlxie wenlxie mentioned this pull request Jun 26, 2018
Merged
@msau42
Copy link
Member

msau42 commented Jun 26, 2018

I think release note is not needed.

msau42
msau42 reviewed Jun 26, 2018
View reviewed changes
pkg/volume/csi/csi_plugin.go
@@ -248,6 +248,7 @@ func (p *csiPlugin) ConstructVolumeSpec(volumeName, mountPath string) (*volume.S

glog.V(4).Info(log("plugin.ConstructVolumeSpec extracted [%#v]", volData))

fsMode := api.PersistentVolumeFilesystem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 Added

@msau42
Copy link
Member

msau42 commented Jun 26, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2018
@msau42
Copy link
Member

msau42 commented Jun 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2018
@msau42
Copy link
Member

msau42 commented Jun 29, 2018

/assign @vladimirvivien

@wenlxie
Copy link
Contributor Author

wenlxie commented Jul 9, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 9, 2018
@k8s-ci-robot
Copy link
Contributor

@wenlxie: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-pr-reviews

In response to this:

@kubernetes/sig-storage-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wenlxie
Copy link
Contributor Author

wenlxie commented Jul 9, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot
Copy link
Contributor

@wenlxie: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-pr-reviews

In response to this:

@kubernetes/sig-storage-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Member

jsafrane commented Jul 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, wenlxie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018 •
edited
Loading

@wenlxie: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 0df13e7 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kops-aws 0df13e7 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65456, 65549). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9cb2ee0 into kubernetes:master Jul 9, 2018
@wenlxie wenlxie deleted the upstream.master.csivolumemode branch October 24, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@vladimirvivien vladimirvivien

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wenlxie @msau42 @k8s-ci-robot @jsafrane @fejta-bot @k8s-github-robot @vladimirvivien