Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add volume mode field to constructed volume spec for CSI plugin #65456

Merged
merged 1 commit into from Jul 9, 2018

Conversation

@wenlxie
Copy link
Contributor

wenlxie commented Jun 26, 2018

Add volume mode filed to constructed Volume Spec for CSI plugin

Add volume mode filed to constructed volume spec for CSI plugin
@wenlxie

This comment has been minimized.

Copy link
Contributor Author

wenlxie commented Jun 26, 2018

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jun 26, 2018

I think release note is not needed.

@@ -248,6 +248,7 @@ func (p *csiPlugin) ConstructVolumeSpec(volumeName, mountPath string) (*volume.S

glog.V(4).Info(log("plugin.ConstructVolumeSpec extracted [%#v]", volData))

fsMode := api.PersistentVolumeFilesystem

This comment has been minimized.

@msau42

msau42 Jun 26, 2018

Member

Add a unit test

This comment has been minimized.

@wenlxie

wenlxie Jun 29, 2018

Author Contributor

@msau42 Added

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jun 26, 2018

/ok-to-test

@wenlxie wenlxie force-pushed the wenlxie:upstream.master.csivolumemode branch from 508d66d to 0df13e7 Jun 29, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jun 29, 2018

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jun 29, 2018

/lgtm

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jun 29, 2018

/assign @vladimirvivien

@wenlxie

This comment has been minimized.

Copy link
Contributor Author

wenlxie commented Jul 9, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018

@wenlxie: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-pr-reviews

In response to this:

@kubernetes/sig-storage-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wenlxie

This comment has been minimized.

Copy link
Contributor Author

wenlxie commented Jul 9, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018

@wenlxie: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-pr-reviews

In response to this:

@kubernetes/sig-storage-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Jul 9, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, wenlxie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 9, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018

@wenlxie: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 0df13e7 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kops-aws 0df13e7 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 9, 2018

Automatic merge from submit-queue (batch tested with PRs 65456, 65549). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9cb2ee0 into kubernetes:master Jul 9, 2018

14 of 17 checks passed

pull-kubernetes-e2e-gce Job failed.
Details
pull-kubernetes-e2e-kops-aws Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation wenlxie authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.