Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug printing openapi columns #65600

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix bug printing openapi columns #65600

merged 1 commit into from
Jun 29, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 28, 2018 •
edited
Loading

Fixes #65579

kubectl: fixes a regression with --use-openapi-print-columns that would not print object contents

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2018
@liggitt liggitt mentioned this pull request Jun 28, 2018
Closed
@liggitt
Copy link
Member Author

liggitt commented Jun 28, 2018

@kubernetes/sig-cli-bugs
/assign @soltysh @juanvallejo

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2018
@liggitt liggitt added this to the v1.11 milestone Jun 28, 2018
@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juanvallejo
Copy link
Contributor

@liggitt can you backport this to 1.11 as well?

@liggitt
Copy link
Member Author

liggitt commented Jun 29, 2018

/status approved-for-milestone
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone labels Jun 29, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@juanvallejo @liggitt @soltysh

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@liggitt liggitt mentioned this pull request Jun 29, 2018
Merged
@liggitt
Copy link
Member Author

liggitt commented Jun 29, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7c1df02 into kubernetes:master Jun 29, 2018
soltysh
soltysh reviewed Jun 29, 2018
View reviewed changes
pkg/kubectl/cmd/get/get.go
@@ -318,6 +318,10 @@ func (o *GetOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []string) e
Latest().
Flatten().
TransformRequests(func(req *rest.Request) {
// We need full objects if printing with openapi columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to do this condition here so that we have all of them in a single place. We'll be fixing this in 1.12, properly.

k8s-github-robot pushed a commit that referenced this pull request Jun 30, 2018
Merge pull request #65602 from liggitt/automated-cherry-pick-of-#6560…
38287de 
…0-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65600: Fix bug printing openapi columns

Cherry pick of #65600 on release-1.11.

#65600: Fix bug printing openapi columns
@liggitt liggitt deleted the use-openapi-print-columns branch July 4, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@juanvallejo juanvallejo juanvallejo approved these changes

@ericchiang ericchiang Awaiting requested review from ericchiang

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@soltysh soltysh

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

kubectl 1.11.0 unable to print resources with OpenAPI custom columns
5 participants
@liggitt @juanvallejo @k8s-ci-robot @k8s-github-robot @soltysh