Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when copy file from host to pod like this: 1.kubectl copy /tmp/test-f… #65709

Merged
merged 1 commit into from
Aug 24, 2018
Merged

when copy file from host to pod like this: 1.kubectl copy /tmp/test-f… #65709

merged 1 commit into from
Aug 24, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jul 2, 2018

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #65530

Special notes for your reviewer:
/assign @juanvallejo
since you were looking at the original one as well.

Release note:

NONE

@WanLinghao @soltysh
when copy file from host to pod like this: 1.kubectl copy /tmp/test-f…
64ac8f3 
…ile test-pod:/ 2.kubectl copy /tmp/test-file test-pod: example 1 will fail, example 2 will cause a panic. This patch fix bugs above.
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 2, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2018
@k8s-ci-robot k8s-ci-robot requested review from ghodss and sttts July 2, 2018 14:02
@soltysh soltysh mentioned this pull request Jul 2, 2018
Closed
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 2, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Jul 2, 2018

/assign @MaciekPytel
for 1.10 approval

@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 3, 2018
@juanvallejo
Copy link
Contributor

/test pull-kubernetes-e2e-gce

@MaciekPytel
Copy link
Contributor

/hold
For 1.10.6

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2018
@MaciekPytel
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2018
@MaciekPytel
Copy link
Contributor

@soltysh Who would be the right approver for this?

@soltysh
Copy link
Contributor Author

soltysh commented Aug 24, 2018

@soltysh Who would be the right approver for this?

@MaciekPytel this is a cherry-pick from current master (not quite clean), and since I co-lead the effort I'd consider myself as the righteous approver, additionally the PR was already verified by Juan.

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Aug 24, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a888fe4 into kubernetes:release-1.10 Aug 24, 2018
@soltysh soltysh deleted the automated-cherry-pick-of-#60565-upstream-release-1.10-1530539685 branch September 21, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@ghodss ghodss Awaiting requested review from ghodss

@sttts sttts Awaiting requested review from sttts

Assignees

@juanvallejo juanvallejo

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@soltysh @juanvallejo @MaciekPytel @k8s-ci-robot @k8s-github-robot @WanLinghao