Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm] Remove usage of PersistentVolumeLabel in phases/controlplane/manifests*.go #65827

Merged

Conversation

xlgao-zju
Copy link
Contributor

What this PR does / why we need it:
Remove usage of PersistentVolumeLabel in phases/controlplane/manifests*.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Close kubernetes/kubeadm#866

Special notes for your reviewer:
/assign @neolit123

Release note:

kubeadm: Remove usage of `PersistentVolumeLabel`

Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 4, 2018
@neolit123
Copy link
Member

seems good. thanks @xlgao-zju

/assign @luxas
/assign @timothysc
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2018
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for this PR 🎉!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, xlgao-zju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2018
@xlgao-zju
Copy link
Contributor Author

@neolit123 I'd like to help more, any of other issues I can help?

@neolit123
Copy link
Member

@xlgao-zju

@neolit123 I'd like to help more, any of other issues I can help?

much appreciated. 👍
you can give this one a shot, but feel free to ask questions in the issue:
kubernetes/kubeadm#805

maybe @detiber and @chuckha have some potential tasks for you as well?

@neolit123
Copy link
Member

we also have a lot of issues with help wanted:
https://github.com/kubernetes/kubeadm/issues?q=label%3A%22help+wanted%22

feel free to help us debug or fix some of the problems there!

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64593, 65117, 65629, 65827, 65686). If you want to cherry-pick this change to another branch, please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of PersistentVolumeLabel in phases/controlplane/manifests*.go
7 participants