-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubeadm] Remove usage of PersistentVolumeLabel
in phases/controlplane/manifests*.go
#65827
[kubeadm] Remove usage of PersistentVolumeLabel
in phases/controlplane/manifests*.go
#65827
Conversation
Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
seems good. thanks @xlgao-zju /assign @luxas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for this PR 🎉!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luxas, xlgao-zju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@neolit123 I'd like to help more, any of other issues I can help? |
much appreciated. 👍 maybe @detiber and @chuckha have some potential tasks for you as well? |
we also have a lot of issues with feel free to help us debug or fix some of the problems there! |
/retest Review the full test history for this PR. Silence the bot with an |
Automatic merge from submit-queue (batch tested with PRs 64593, 65117, 65629, 65827, 65686). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Remove usage of
PersistentVolumeLabel
in phases/controlplane/manifests*.goWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Close kubernetes/kubeadm#866
Special notes for your reviewer:
/assign @neolit123
Release note: