Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix visibility of testdata for //test/cmd:legacy-script #65927

Merged
merged 3 commits into from Jul 8, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions build/visible_to/BUILD
Expand Up @@ -40,6 +40,7 @@ package_group(
"//hack",
"//hack/lib",
"//hack/make-rules",
"//test/cmd",
"//test/e2e/...",
"//test/integration/...",
],
Expand Down
2 changes: 1 addition & 1 deletion hack/make-rules/BUILD
Expand Up @@ -21,7 +21,7 @@ sh_binary(
srcs = ["test-cmd.sh"],
deps = [
"//hack/lib",
"//test/cmd:all-srcs",
"//test/cmd:legacy-script",
],
)

Expand Down
49 changes: 2 additions & 47 deletions test/cmd/BUILD
@@ -1,53 +1,8 @@
# Scripts runnable from make, e.g.
#
# cd $GOPATH/src/k8s.io/kubernetes
# make test-e2e-node
#
# The sh_binary rules below exist only to validate
# dependencies; if a shell dependency is accidentally
# deleted, a presubmit BUILD will fail.
#
# If the scripts sourced their dependencies from
# $RUNFILES (rather than $BASH_SOURCE/../.. or
# whatever), then bazel build hack/... would install
# runnable, hermetically sealed shell "binaries".
# E.g. the following command would work:
#
# ./bazel-bin/hack/make-rules/test-e2e-node
#
# TODO(#47064): Should be a sh_test instead of sh_binary

sh_library(
name = "legacy-script",
srcs = [
"apply.sh",
"apps.sh",
"authorization.sh",
"batch.sh",
"certificate.sh",
"core.sh",
"crd.sh",
"create.sh",
"diff.sh",
"discovery.sh",
"generic-resources.sh",
"get.sh",
"initializers.sh",
"kubeconfig.sh",
"legacy-script.sh",
"node-management.sh",
"old-print.sh",
"plugins.sh",
"proxy.sh",
"rbac.sh",
"request-timeout.sh",
"run.sh",
"save-config.sh",
"storage.sh",
"template-output.sh",
"version.sh",
],
srcs = glob(["*.sh"]),
data = ["//pkg/kubectl/validation:testdata/v1/validPod.yaml"],
visibility = ["//visibility:public"],
)

filegroup(
Expand Down