New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change TRUNCATED to DATA+OMITTED in kubectl config view #66023

Merged
merged 1 commit into from Aug 18, 2018

Conversation

@ibrasho
Contributor

ibrasho commented Jul 10, 2018

What this PR does / why we need it:
Based on the discussion in #61573, this PR switches the replacement text for CA certificate data and client certificates and secrets printed using kubectl config view. Currently, REDACTED is used, which might give a false impression that the data is a secret (which is not true for the public certificates).

This PR changes REDACTED to DATA+OMITTED. The printed string is the base64 encoded string on the byte stream. Some trickery is involved to print a readable string (refer to this comment for more info).

Which issue(s) this PR fixes:
Fixes #61573

Special notes for your reviewer:

Release note:

Switched certificate data replacement from "REDACTED" to "DATA+OMITTED"

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jul 20, 2018

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo commented Jul 20, 2018

LGTM

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Jul 31, 2018

Member

/ok-to-test

Member

dims commented Jul 31, 2018

/ok-to-test

@ibrasho

This comment has been minimized.

Show comment
Hide comment
@ibrasho

ibrasho Aug 1, 2018

Contributor

/test pull-kubernetes-bazel-test

Contributor

ibrasho commented Aug 1, 2018

/test pull-kubernetes-bazel-test

@ibrasho

This comment has been minimized.

Show comment
Hide comment
@ibrasho

ibrasho Aug 1, 2018

Contributor

/assign @caesarxuchao

Contributor

ibrasho commented Aug 1, 2018

/assign @caesarxuchao

change TRUNCATED to DATA+OMITTED in kubectl config view
Signed-off-by: Ibrahim AshShohail <me@ibrasho.com>
@ibrasho

This comment has been minimized.

Show comment
Hide comment
@ibrasho

ibrasho Aug 1, 2018

Contributor

/retest

Contributor

ibrasho commented Aug 1, 2018

/retest

@ibrasho

This comment has been minimized.

Show comment
Hide comment
@ibrasho

ibrasho Aug 1, 2018

Contributor

Unrelated failures?

Contributor

ibrasho commented Aug 1, 2018

Unrelated failures?

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Aug 3, 2018

All the test failures seem unrelated to me

sethvargo commented Aug 3, 2018

All the test failures seem unrelated to me

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Aug 16, 2018

@ibrasho thanks for doing this work. What do we need to do to get this into a release?

sethvargo commented Aug 16, 2018

@ibrasho thanks for doing this work. What do we need to do to get this into a release?

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao Aug 17, 2018

Member

/lgtm

Member

caesarxuchao commented Aug 17, 2018

/lgtm

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao Aug 17, 2018

Member

/retest

Member

caesarxuchao commented Aug 17, 2018

/retest

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 17, 2018

Contributor

/lgtm

Contributor

yliaog commented Aug 17, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 17, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, ibrasho, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, ibrasho, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 17, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Aug 17, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

/test all

Tests are more than 96 hours old. Re-running tests.

Contributor

k8s-merge-robot commented Aug 18, 2018

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 18, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 60790, 66023, 67549). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 18, 2018

Automatic merge from submit-queue (batch tested with PRs 60790, 66023, 67549). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit ae9beb4 into kubernetes:master Aug 18, 2018

9 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation ibrasho authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-typecheck Job succeeded.
Details
@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 24, 2018

Member

/sig api-machinery
for the release note tool.

Member

neolit123 commented Aug 24, 2018

/sig api-machinery
for the release note tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment