Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #65908: switch delete strategy to background deletion #66024

Merged
merged 2 commits into from Jul 12, 2018
Merged

Automated cherry pick of #65908: switch delete strategy to background deletion #66024

merged 2 commits into from Jul 12, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 10, 2018 •
edited

Cherry pick of #65908 on release-1.11.

Fixes #66110

includes related test fix #66038

#65908: switch delete strategy to background deletion

`kubectl delete` now deletes daemonset, deployment, statefulset, replicaset, replicationcontroller, and job objects immediately and delegates cleanup of child resources to server-side garbage collection in the background. This resolves hangs that could occur if garbage collection was not responsive when `kubectl delete` was invoked.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 10, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2018
@liggitt
Copy link
Member Author

liggitt commented Jul 10, 2018

/sig cli
/kind bug
/priority important-soon
/milestone v1.11
/status approved-for-milestone

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 10, 2018
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 10, 2018
@liggitt liggitt mentioned this pull request Jul 10, 2018
Merged
@liggitt
Copy link
Member Author

liggitt commented Jul 10, 2018

@kubernetes/sig-cli-pr-reviews

@liggitt
Copy link
Member Author

liggitt commented Jul 10, 2018

/assign @juanvallejo @foxish

@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 10, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@foxish @juanvallejo @liggitt

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2018
@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the automated-cherry-pick-of-#65908-upstream-release-1.11 branch from 9aceab2 to 8b57efc Compare July 10, 2018 19:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@juanvallejo
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@liggitt
Copy link
Member Author

liggitt commented Jul 11, 2018

@foxish for branch approval

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 11, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt liggitt mentioned this pull request Jul 12, 2018
Closed
@liggitt
Copy link
Member Author

liggitt commented Jul 12, 2018

/retest

@juanvallejo
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@liggitt
Copy link
Member Author

liggitt commented Jul 12, 2018

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jul 12, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 1580336 into kubernetes:release-1.11 Jul 12, 2018
@liggitt liggitt mentioned this pull request Jul 24, 2018
Closed
@nilebox nilebox mentioned this pull request Aug 17, 2018
Closed
@jnummelin jnummelin mentioned this pull request Sep 7, 2018
Merged
@liggitt liggitt deleted the automated-cherry-pick-of-#65908-upstream-release-1.11 branch April 22, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@foxish foxish

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @juanvallejo @k8s-github-robot @k8s-ci-robot @fejta-bot @foxish