Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #65499: Removes defaulting of CSI fsType to ext4 #66037

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Automated cherry pick of #65499: Removes defaulting of CSI fsType to ext4 #66037

merged 2 commits into from
Jul 12, 2018

Conversation

krunaljain
Copy link
Contributor

@krunaljain krunaljain commented Jul 10, 2018 •
edited

Cherry pick of #65499 on release-1.11.

#65499: Removes defaulting of CSI fsType to ext4

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2018
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 10, 2018
@msau42
Copy link
Member

msau42 commented Jul 10, 2018

/ok-to-test
/lgtm
/assign @liggitt @vladimirvivien

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2018
@vladimirvivien
Copy link
Member

/lgtm

1 similar comment
@liggitt
Copy link
Member

liggitt commented Jul 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2018
@msau42
Copy link
Member

msau42 commented Jul 10, 2018

/lgtm cancel
The types.go comments changes are on the wrong types. master needs to be fixed too

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@liggitt
Copy link
Member

liggitt commented Jul 10, 2018

Good catch. Thanks.

@krunaljain
Removes defaulting of CSI fsType to ext4
dabb7b7 
Fixing comments in types.go
@krunaljain
Adding generated files
2c3f85d 
Adding generated files
@krunaljain krunaljain force-pushed the automated-cherry-pick-of-#65499-upstream-release-1.11 branch from c813057 to 2c3f85d Compare July 11, 2018 01:51
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2018
@krunaljain
Copy link
Contributor Author

/assign @msau42

@liggitt
Copy link
Member

liggitt commented Jul 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2018
@saad-ali saad-ali added this to the v1.11 milestone Jul 11, 2018
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krunaljain, liggitt, saad-ali, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krunaljain
Copy link
Contributor Author

krunaljain commented Jul 11, 2018 •
edited

/kind bug
/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 11, 2018
@msau42
Copy link
Member

msau42 commented Jul 11, 2018

/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 11, 2018
@foxish foxish added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 12, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@krunaljain @liggitt @msau42 @saad-ali @vladimirvivien

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 21591cb into kubernetes:release-1.11 Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@vladimirvivien vladimirvivien

@liggitt liggitt

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@krunaljain @msau42 @vladimirvivien @liggitt @saad-ali @k8s-ci-robot @k8s-github-robot @foxish