Autoset OpenAPI version w/o SecurityDefinitions #66411
Conversation
k8s-ci-robot
added
size/XS
|
cc @kubernetes/sig-api-machinery-bugs @kubernetes/sig-api-machinery-pr-reviews |
k8s-ci-robot
added
sig/api-machinery
|
I'm assuming this wasn't intentional -- it doesn't seem like it should be the case. |
| @@ -387,7 +387,8 @@ func (c *Config) Complete(informers informers.SharedInformerFactory) CompletedCo | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| } | |||
| if c.OpenAPIConfig != nil { | |||
There was a problem hiding this comment.
sgtm. It would maybe clearer to keep everything in the if c.OpenAPIConfig != nil block, but guard only the above code with c.OpenAPIConfig.SecurityDefinitions != nil.
There was a problem hiding this comment.
either works for me. I went for the route of "less nested indentation", but the other way seems clearer in other regards. I'll switch.
There's code to automatically populate OpenAPI info based on existing generic apiserver config, but it only fires if securitydefinitions are present. This doesn't make much sense, since this info is both required and independent of security definitions, and there's no easy, generic way to generate security definitions for an aggregated API server.
DirectXMan12
force-pushed
the
bug/allow-setting-openapi-version-with-sec
branch
from
9aca723
to
ef73bb6
Compare
k8s-ci-robot
added
size/M
|
/assign @sttts |
|
/cc @mbohlool |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
/lgtm |
There's code to automatically populate OpenAPI info based on existing
generic apiserver config, but it only fires if securitydefinitions are
present. This doesn't make much sense, since this info is both required
and independent of security definitions, and there's no easy, generic
way to generate security definitions for an aggregated API server.
Release note: