Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #66425: Do not attempt to convert nil object during DELETE webhook #66426

Merged
merged 1 commit into from Jul 24, 2018
Merged

Automated cherry pick of #66425: Do not attempt to convert nil object during DELETE webhook #66426

merged 1 commit into from Jul 24, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 20, 2018 •
edited

Cherry pick of #66425 on release-1.11.

#66425: Do not attempt to convert nil object during DELETE webhook

fixes a panic when using a mutating webhook admission plugin with a DELETE operation

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 20, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 20, 2018
@liggitt liggitt mentioned this pull request Jul 20, 2018
Closed
@sttts
Copy link
Contributor

sttts commented Jul 20, 2018

Lgtm in general. Just the nit about the error message in the original PR.

@liggitt liggitt force-pushed the automated-cherry-pick-of-#66425-upstream-release-1.11 branch from f355313 to a8af31b Compare July 20, 2018 12:32
@liggitt
Copy link
Member Author

liggitt commented Jul 20, 2018

updated

@liggitt
Copy link
Member Author

liggitt commented Jul 20, 2018

/kind bug
/sig api-machinery
/priority critical-urgent
/milestone v1.11
/status approved-for-milestone
/assign @foxish @sttts

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. status/approved-for-milestone sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 20, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@foxish @liggitt @sttts

Pull Request Labels
  • sig/api-machinery: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@sttts
Copy link
Contributor

sttts commented Jul 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Jul 20, 2018

/retest

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 23, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 36aa761 into kubernetes:release-1.11 Jul 24, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#66425-upstream-release-1.11 branch April 22, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@foxish foxish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @sttts @k8s-github-robot @k8s-ci-robot @fejta-bot @foxish