Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop rest.ConnectRequest in webhook admission #66633

Closed
wants to merge 1 commit into from
Closed

drop rest.ConnectRequest in webhook admission #66633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/generic/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ func (a *Webhook) Dispatch(attr admission.Attributes) error {
}
versionedAttr.VersionedOldObject = out
}
if obj := attr.GetObject(); obj != nil {
// Don't try to convert CONNECT requests because the object will be a
// rest.ConnectRequest. This will cause the converter to return an error. For
// now, just drop that information and continue with the admission check.
if obj := attr.GetObject(); obj != nil && attr.GetOperation() != admission.Connect {
out, err := a.convertor.ConvertToGVK(obj, attr.GetKind())
if err != nil {
return apierrors.NewInternalError(err)
Expand Down