Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #59686: Add cloud-provider policies to be applied via addon mgr #66939

Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #59686: Add cloud-provider policies to be applied via addon mgr #66939

wants to merge 1 commit into from

Conversation

grayluck
Copy link
Contributor

@grayluck grayluck commented Aug 2, 2018

Cherry pick of #59686 on release-1.8.

#59686: Add cloud-provider policies to be applied via addon mgr

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2018
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 2, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grayluck
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jszczepkowski

If they are not already assigned, you can assign the PR to them by writing /assign @jszczepkowski in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grayluck
Copy link
Contributor Author

grayluck commented Aug 2, 2018

/priority important-soon
/sig auth
/release-note-none

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/auth Categorizes an issue or PR as relevant to SIG Auth. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 2, 2018
@grayluck
Copy link
Contributor Author

grayluck commented Aug 2, 2018

/assign @bowei

@grayluck
Copy link
Contributor Author

grayluck commented Aug 2, 2018

/assign @tallclair @liggitt

@tallclair
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2018
@tallclair
Copy link
Member

I thought we were done with 1.8 releases?

@grayluck
Copy link
Contributor Author

grayluck commented Aug 2, 2018

Yes seems like we are. Thanks Tim!
But we still need #66872 for 1.9.

@grayluck grayluck closed this Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@bowei bowei

@tallclair tallclair

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@grayluck @k8s-github-robot @k8s-ci-robot @tallclair @bowei @liggitt