Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #66485: A large set of improvements to the Stackdriver components. #67025

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Automated cherry pick of #66485: A large set of improvements to the Stackdriver components. #67025

merged 1 commit into from
Aug 8, 2018

Conversation

bmoyles0117
Copy link
Contributor

Cherry pick of #66485 on release-1.10.

#66485: A large set of improvements to the Stackdriver components.

@bmoyles0117
A large set of improvements to the Stackdriver components.
f974f0a 
Metadata Agent Improvements
Bump metadata agent version to 0.2-0.0.21-1.
Expand the metadata agent's access to all API groups.
Remove metadata agent config maps in favor of command line flags.
Update the metadata agent's liveness probe to a new /healthz handler.

Logging Agent Improvements
Bump logging agent version to 0.2-1.5.33-1-k8s-1.
Appropriately set log severity for k8s_container.
Fix detect exceptions plugin to analyze message field instead of log field.
Fix detect exceptions plugin to analyze streams based on local resource id.
Disable the metadata agent for monitored resource construction in logging.
Disable timestamp adjustment in logs to optimize performance.
Reduce logging agent buffer chunk limit to 512k to optimize performance.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 6, 2018
@x13n
Copy link
Member

x13n commented Aug 6, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2018
@MaciekPytel
Copy link
Contributor

/retest
/approve
For cluster/gce.

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 7, 2018
@MaciekPytel
Copy link
Contributor

@piosz Can you approve?

@bmoyles0117
Copy link
Contributor Author

Friendly ping, the cherrypick into 1.11 went through without incident.
#67021

@MaciekPytel
Copy link
Contributor

In 1.11 @x13n is an approver for cluster/addons/fluentd-gcp, but adding him to OWNERS file was not cherry-picked to 1.10, so only @piosz can approve this.

piosz
piosz reviewed Aug 8, 2018
View reviewed changes
cluster/addons/fluentd-gcp/fluentd-gcp-configmap.yaml
@@ -108,8 +110,8 @@ data:
@type detect_exceptions

remove_tag_prefix raw
message log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is different that the one in the original PR. Is this intended? If yes please explain why in the PR description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only different because it has been merged in master between 1.10 and 1.11, this is the intended value to properly capture exceptions.

@piosz
Copy link
Member

piosz commented Aug 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmoyles0117, MaciekPytel, piosz, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@bmoyles0117
Copy link
Contributor Author

/retest pull-kubernetes-e2e-gke

@bmoyles0117
Copy link
Contributor Author

/test pull-kubernetes-e2e-gke

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 8619d22 into kubernetes:release-1.10 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz piosz left review comments

@crassirostris crassirostris Awaiting requested review from crassirostris

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@x13n x13n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bmoyles0117 @x13n @MaciekPytel @piosz @k8s-ci-robot @k8s-github-robot