Do not count soft-deleted pods for scaling purposes in HPA controller #67067

moonek · 2018-08-07T08:42:30Z

What this PR does / why we need it:
The metrics of "soft-deleted" pods in general to be deleted should probably not matter for scaling purposes, since they'll be gone "soon", whether they're nodelost or just normally delete.

As long as soft-deleted pods still exist, they prevent normal scale up.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62845

Special notes for your reviewer:

Release note:

Stop counting soft-deleted pods for scaling purposes in HPA controller to avoid soft-deleted pods incorrectly affecting scale up replica count calculation.

moonek · 2018-08-07T09:14:17Z

/assign @DirectXMan12

DirectXMan12 · 2018-08-07T19:55:07Z

@kubernetes/sig-autoscaling-pr-reviews

EDIT: the right SIG, sorry for the mistype

MHBauer · 2018-08-08T01:25:51Z

/ok-to-test

moonek · 2018-08-08T02:46:21Z

How can I pass the test?
My commit is not a breaking change.

liggitt · 2018-08-08T03:22:21Z

see https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67067/pull-kubernetes-verify/101321/

diff -Naupr -x _output /go/src/k8s.io/kubernetes/pkg/controller/podautoscaler/BUILD /tmp/verify-bazel.3ZRogM/go/src/k8s.io/kubernetes/pkg/controller/podautoscaler/BUILD
--- /go/src/k8s.io/kubernetes/pkg/controller/podautoscaler/BUILD	2018-08-08 01:27:28.692897252 +0000
+++ /tmp/verify-bazel.3ZRogM/go/src/k8s.io/kubernetes/pkg/controller/podautoscaler/BUILD	2018-08-08 01:30:54.880071889 +0000
@@ -20,6 +20,7 @@ go_library(
         "//pkg/api/v1/pod:go_default_library",
         "//pkg/controller:go_default_library",
         "//pkg/controller/podautoscaler/metrics:go_default_library",
+        "//pkg/util/node:go_default_library",
         "//staging/src/k8s.io/api/autoscaling/v1:go_default_library",
         "//staging/src/k8s.io/api/autoscaling/v2beta1:go_default_library",
         "//staging/src/k8s.io/api/core/v1:go_default_library",

Run ./hack/update-bazel.sh

you need to run hack/update-bazel.sh and commit the results

moonek · 2018-08-08T05:41:33Z

/retest

moonek · 2018-08-08T08:15:08Z

How do I pass pull-kubernetes-e2e-kops-aws? I don't think this is a problem I can solve.

moonek · 2018-08-08T13:13:38Z

/retest

moonek · 2018-08-09T02:59:26Z

@MaciekPytel @jszczepkowski @DirectXMan12 ptal, this issue has been reported as a serious issue in the node failure test for production-grade k8s use.

moonek · 2018-08-09T06:30:16Z

test code added.

moonek · 2018-08-09T09:14:29Z

/retest

fedebongio · 2018-08-09T20:11:11Z

/remove-sig api-machinery

DirectXMan12 · 2018-08-13T19:01:07Z

The code looks fine here, but I want to clarify what happened. AIUI, when the pods are set as nodelost, they should be deleted shortly thereafter by the node controller, so we shouldn't have an issue with them hanging around forever. Perhaps someone from @kubernetes/sig-node-bugs can weigh in?

moonek · 2018-08-14T00:23:58Z

@DirectXMan12 If you expect the node controller to delete the nodelost pod, this is clearly an HPA bug.
K8s since version 1.5, the node controller has been changed so that it no longer forcibly deletes pods.
#35235
#35145
#51333

If the administrator does not forcibly delete the nodelost pod, it will not scale up forever.

moonek · 2018-08-22T05:35:09Z

@DirectXMan12 I want to know how the review is currently in progress. I want to avoid rebase.

k8s-ci-robot · 2018-08-25T04:58:19Z

@moonek: Those labels are not set on the issue: area/apiserver

In response to this:

/remove-area apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-08-25T04:58:38Z

@moonek: Those labels are not set on the issue: sig/api-machinery, sig/cli, sig/cloud-provider, sig/cluster-lifecycle, sig/release, sig/scheduling, area/apiserver

In response to this:

/remove-sig api-machinery
/remove-sig cli
/remove-sig cloud-provider
/remove-sig cluster-lifecycle
/remove-sig release
/remove-sig scheduling
/remove-area apiserver
/remove-area kubeadm
/remove-area kubectl
/remove-area kubelet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-08-25T06:21:31Z

@moonek: Those labels are not set on the issue: sig/api-machinery, sig/cli, sig/cloud-provider, sig/cluster-lifecycle, sig/release, sig/scheduling, area/apiserver, area/kubeadm, area/kubectl, area/kubelet

In response to this:

/remove-sig api-machinery
/remove-sig cli
/remove-sig cloud-provider
/remove-sig cluster-lifecycle
/remove-sig release
/remove-sig scheduling
/remove-area apiserver
/remove-area kubeadm
/remove-area kubectl
/remove-area kubelet

oops.. It was a rebase accident.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

moonek · 2018-08-25T06:26:34Z

/retest

moonek · 2018-08-27T16:56:07Z

@DirectXMan12 Is it difficult for this fix to be merged into 1.12?

DirectXMan12 · 2018-08-27T20:59:14Z

@moonek I'd like to get it merged for 1.12. I'm planning on doing one last review pass tomorrow, then approving it.

DirectXMan12

minor test-related change, otherwise this is good to go

DirectXMan12 · 2018-08-28T14:01:54Z

pkg/controller/podautoscaler/horizontal_test.go

 								},
 							},
 						},
 					},
-				},
+				}
+			} else {


you shouldn't be creating the entire object in the if-else, just setting the DeletionTimestamp:

pod = v1.Pod{...} if deletionTimestamp { pod.DeletionTimestamp = &metav1.Time{Time: time.Now()} }

DirectXMan12 · 2018-08-28T14:02:27Z

pkg/controller/podautoscaler/replica_calculator_test.go

-							Type:   v1.PodReady,
-							Status: podReadiness,
+			pod := v1.Pod{}
+			if podDeletionTimestamp == false {


moonek · 2018-08-28T16:38:47Z

@DirectXMan12 I was also concerned about that part. I modified and re-committed.

DirectXMan12 · 2018-08-28T17:05:47Z

/lgtm
/approve

k8s-ci-robot · 2018-08-28T17:05:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, moonek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controller/podautoscaler/OWNERS~~ [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

DirectXMan12 · 2018-08-28T17:33:17Z

/retest

k8s-ci-robot · 2018-08-28T18:01:50Z

@moonek: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-cross	749f8be3c173c070412e4586809c6dec8b1e2c7d	link	`/test pull-kubernetes-cross`
pull-kubernetes-local-e2e-containerized	749f8be3c173c070412e4586809c6dec8b1e2c7d	link	`/test pull-kubernetes-local-e2e-containerized`
pull-kubernetes-local-e2e	749f8be3c173c070412e4586809c6dec8b1e2c7d	link	`/test pull-kubernetes-local-e2e`
pull-kubernetes-e2e-gke	749f8be3c173c070412e4586809c6dec8b1e2c7d	link	`/test pull-kubernetes-e2e-gke`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

moonek · 2018-08-28T18:27:46Z

/retest

k8s-github-robot · 2018-08-28T21:57:41Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-08-28T22:08:00Z

Automatic merge from submit-queue (batch tested with PRs 67067, 67947). If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot requested review from jszczepkowski and MaciekPytel August 7, 2018 08:42

k8s-ci-robot assigned DirectXMan12 Aug 7, 2018

k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 7, 2018

k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Aug 7, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2018

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2018

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 9, 2018

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. labels Aug 13, 2018

k8s-ci-robot removed area/kubeadm area/kubectl labels Aug 25, 2018

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed area/kubelet needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 25, 2018

DirectXMan12 suggested changes Aug 28, 2018

View reviewed changes

Do not count soft-deleted pods for scaling purposes in HPA controller

3fedbe4

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2018

k8s-github-robot merged commit 42c6f1f into kubernetes:master Aug 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not count soft-deleted pods for scaling purposes in HPA controller #67067

Do not count soft-deleted pods for scaling purposes in HPA controller #67067

moonek commented Aug 7, 2018 •

edited

Loading

moonek commented Aug 7, 2018

DirectXMan12 commented Aug 7, 2018

MHBauer commented Aug 8, 2018

moonek commented Aug 8, 2018

liggitt commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 9, 2018

moonek commented Aug 9, 2018

moonek commented Aug 9, 2018

fedebongio commented Aug 9, 2018

DirectXMan12 commented Aug 13, 2018

moonek commented Aug 14, 2018 •

edited

Loading

moonek commented Aug 22, 2018

k8s-ci-robot commented Aug 25, 2018

k8s-ci-robot commented Aug 25, 2018

k8s-ci-robot commented Aug 25, 2018

moonek commented Aug 25, 2018

moonek commented Aug 27, 2018

DirectXMan12 commented Aug 27, 2018

DirectXMan12 left a comment

DirectXMan12 Aug 28, 2018

DirectXMan12 Aug 28, 2018

moonek commented Aug 28, 2018

DirectXMan12 commented Aug 28, 2018

k8s-ci-robot commented Aug 28, 2018

DirectXMan12 commented Aug 28, 2018

k8s-ci-robot commented Aug 28, 2018 •

edited

Loading

moonek commented Aug 28, 2018

k8s-github-robot commented Aug 28, 2018

k8s-github-robot commented Aug 28, 2018

Do not count soft-deleted pods for scaling purposes in HPA controller #67067

Do not count soft-deleted pods for scaling purposes in HPA controller #67067

Conversation

moonek commented Aug 7, 2018 • edited Loading

moonek commented Aug 7, 2018

DirectXMan12 commented Aug 7, 2018

MHBauer commented Aug 8, 2018

moonek commented Aug 8, 2018

liggitt commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 8, 2018

moonek commented Aug 9, 2018

moonek commented Aug 9, 2018

moonek commented Aug 9, 2018

fedebongio commented Aug 9, 2018

DirectXMan12 commented Aug 13, 2018

moonek commented Aug 14, 2018 • edited Loading

moonek commented Aug 22, 2018

k8s-ci-robot commented Aug 25, 2018

k8s-ci-robot commented Aug 25, 2018

k8s-ci-robot commented Aug 25, 2018

moonek commented Aug 25, 2018

moonek commented Aug 27, 2018

DirectXMan12 commented Aug 27, 2018

DirectXMan12 left a comment

Choose a reason for hiding this comment

DirectXMan12 Aug 28, 2018

Choose a reason for hiding this comment

DirectXMan12 Aug 28, 2018

Choose a reason for hiding this comment

moonek commented Aug 28, 2018

DirectXMan12 commented Aug 28, 2018

k8s-ci-robot commented Aug 28, 2018

DirectXMan12 commented Aug 28, 2018

k8s-ci-robot commented Aug 28, 2018 • edited Loading

moonek commented Aug 28, 2018

k8s-github-robot commented Aug 28, 2018

k8s-github-robot commented Aug 28, 2018

moonek commented Aug 7, 2018 •

edited

Loading

moonek commented Aug 14, 2018 •

edited

Loading

k8s-ci-robot commented Aug 28, 2018 •

edited

Loading