Output volumes (capacity, requested) along with cpu and memory when BalanceAttachedNodeVolumes is enabled. #67094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resource allocation priority function.
…mory when the feature BalanceAttachedNodeVolumes is used.
k8s-ci-robot
added
sig/scheduling
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-e2e-kops-aws |
| @@ -56,20 +58,31 @@ func (r *ResourceAllocationPriority) PriorityMap( | |||
| requested.Memory += nodeInfo.NonZeroRequest().Memory | |||
| var score int64 | |||
| // Check if the pod has volumes and this could be added to scorer function for balanced resource allocation. | |||
| if len(pod.Spec.Volumes) >= 0 && nodeInfo.TransientInfo != nil { | |||
| if len(pod.Spec.Volumes) >= 0 && utilfeature.DefaultFeatureGate.Enabled(features.BalanceAttachedNodeVolumes) && nodeInfo.TransientInfo != nil { | |||
There was a problem hiding this comment.
I think we are checking feature gate in scorer function but it won't hurt to check it here as well.
ravisantoshgudimetla
approved these changes
Aug 7, 2018
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 67052, 67094, 66795). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 commits:
One commit fixes incorrect reporting of total request of cpu and memory. Without this commit, see the erroneous output where total request is more than capacity when the pod is allowed to admit.
The other commit adds outputting volumes (capacity, requested) too along with cpu and memory when BalanceAttachedNodeVolumes is enabled.
@kubernetes/sig-scheduling-pr-reviews @bsalamat @k82cn @ravisantoshgudimetla