Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use v1 version of advanced audit policy in gce shell #67174

Merged
merged 1 commit into from
Sep 24, 2018
Merged

use v1 version of advanced audit policy in gce shell #67174

merged 1 commit into from
Sep 24, 2018

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Aug 9, 2018

audit api version has been updated to v1 #65891

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2018
@yue9944882 yue9944882 mentioned this pull request Aug 9, 2018
Closed
@ChiuWang
Copy link
Contributor Author

@thockin @bowei PTAL

@ChiuWang
Copy link
Contributor Author

ChiuWang commented Aug 30, 2018 •
edited
Loading

/assign @tallclair
PTAL

@k8s-ci-robot
Copy link
Contributor

@charrywanganthony: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @tallclair PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2018
@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
@ChiuWang
Copy link
Contributor Author

ChiuWang commented Sep 3, 2018 •
edited
Loading

/assign @yujuhong
PTAL

@k8s-ci-robot
Copy link
Contributor

@charrywanganthony: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @yujuhong PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChiuWang
Copy link
Contributor Author

ChiuWang commented Sep 3, 2018

/test pull-kubernetes-e2e-gke

@ChiuWang
Copy link
Contributor Author

ChiuWang commented Sep 4, 2018

/retest

@yujuhong
Copy link
Contributor

yujuhong commented Sep 5, 2018

/assign @filbranden
for approval

@filbranden
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, filbranden, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 74e6ee1 into kubernetes:master Sep 24, 2018
@ChiuWang ChiuWang deleted the auditv1beta1Tov1_gce.sh branch September 27, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@filbranden filbranden

@yujuhong yujuhong

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ChiuWang @k8s-ci-robot @idealhack @tallclair @yujuhong @filbranden @fejta-bot