New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --dns-loop-detect option to dnsmasq run by kube-dns #67302

Merged
merged 1 commit into from Aug 18, 2018

Conversation

@dixudx
Member

dixudx commented Aug 11, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67299

Special notes for your reviewer:
/cc @kubernetes/sig-network-pr-reviews

Release note:

add --dns-loop-detect option to dnsmasq run by kube-dns
@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx

dixudx Aug 12, 2018

Member

/retest

Member

dixudx commented Aug 12, 2018

/retest

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 12, 2018

Member

--dns-loop-detect
Enable code to detect DNS forwarding loops; ie the situation where a query sent to one of the upstream server eventually returns as a new query to the dnsmasq instance. The process works by generating TXT queries of the form .test and sending them to each upstream server. The hex is a UID which encodes the instance of dnsmasq sending the query and the upstream server to which it was sent. If the query returns to the server which sent it, then the upstream server through which it was sent is disabled and this event is logged. Each time the set of upstream servers changes, the test is re-run on all of them, including ones which were previously disabled.

there might be a slight performance impact.
but given:

  • this is a bug fix
  • we are deprecating kube-dns

LGTM

Member

neolit123 commented Aug 12, 2018

--dns-loop-detect
Enable code to detect DNS forwarding loops; ie the situation where a query sent to one of the upstream server eventually returns as a new query to the dnsmasq instance. The process works by generating TXT queries of the form .test and sending them to each upstream server. The hex is a UID which encodes the instance of dnsmasq sending the query and the upstream server to which it was sent. If the query returns to the server which sent it, then the upstream server through which it was sent is disabled and this event is logged. Each time the set of upstream servers changes, the test is re-run on all of them, including ones which were previously disabled.

there might be a slight performance impact.
but given:

  • this is a bug fix
  • we are deprecating kube-dns

LGTM

@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx
Member

dixudx commented Aug 13, 2018

@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx

dixudx Aug 13, 2018

Member

/kind bug

Kube-dns will still co-exist for several releases according to deprecation policy. We need to fix it.

Member

dixudx commented Aug 13, 2018

/kind bug

Kube-dns will still co-exist for several releases according to deprecation policy. We need to fix it.

@feiskyer

This comment has been minimized.

Show comment
Hide comment
@feiskyer

feiskyer Aug 13, 2018

Member

LGTM. @MrHohn could you also take a look?

/assign @MrHohn

Member

feiskyer commented Aug 13, 2018

LGTM. @MrHohn could you also take a look?

/assign @MrHohn

@MrHohn

MrHohn approved these changes Aug 14, 2018

Did some manual testing this seems to work.

LGTMing per the explanation on #67299 (comment).
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 14, 2018

@MrHohn

This comment has been minimized.

Show comment
Hide comment
@MrHohn

MrHohn Aug 14, 2018

Member

@bowei @tuminoid this might fix kubernetes/dns#169 as well.

Member

MrHohn commented Aug 14, 2018

@bowei @tuminoid this might fix kubernetes/dns#169 as well.

@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx

dixudx Aug 16, 2018

Member

ping @timothysc @fabianofranz for approval. Thanks.

Member

dixudx commented Aug 16, 2018

ping @timothysc @fabianofranz for approval. Thanks.

@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx

dixudx Aug 16, 2018

Member

/retest

Member

dixudx commented Aug 16, 2018

/retest

@timothysc

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 18, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, MrHohn, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, MrHohn, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 18, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 18, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 3142046 into kubernetes:master Aug 18, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@dixudx dixudx deleted the dixudx:dnsmasq_add_loop_detect branch Aug 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment