Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --dns-loop-detect option to dnsmasq run by kube-dns #67302

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 11, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67299

Special notes for your reviewer:
/cc @kubernetes/sig-network-pr-reviews

Release note:

add --dns-loop-detect option to dnsmasq run by kube-dns

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 11, 2018
@dixudx
Copy link
Member Author

dixudx commented Aug 12, 2018

/retest

@neolit123
Copy link
Member

--dns-loop-detect
Enable code to detect DNS forwarding loops; ie the situation where a query sent to one of the upstream server eventually returns as a new query to the dnsmasq instance. The process works by generating TXT queries of the form .test and sending them to each upstream server. The hex is a UID which encodes the instance of dnsmasq sending the query and the upstream server to which it was sent. If the query returns to the server which sent it, then the upstream server through which it was sent is disabled and this event is logged. Each time the set of upstream servers changes, the test is re-run on all of them, including ones which were previously disabled.

there might be a slight performance impact.
but given:

  • this is a bug fix
  • we are deprecating kube-dns

LGTM

@dixudx
Copy link
Member Author

dixudx commented Aug 13, 2018

/assign @m1093782566 @feiskyer

@dixudx
Copy link
Member Author

dixudx commented Aug 13, 2018

/kind bug

Kube-dns will still co-exist for several releases according to deprecation policy. We need to fix it.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 13, 2018
@feiskyer
Copy link
Member

LGTM. @MrHohn could you also take a look?

/assign @MrHohn

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual testing this seems to work.

LGTMing per the explanation on #67299 (comment).
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@MrHohn
Copy link
Member

MrHohn commented Aug 14, 2018

@bowei @tuminoid this might fix kubernetes/dns#169 as well.

@dixudx
Copy link
Member Author

dixudx commented Aug 16, 2018

ping @timothysc @fabianofranz for approval. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Aug 16, 2018

/retest

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, MrHohn, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3142046 into kubernetes:master Aug 18, 2018
@dixudx dixudx deleted the dnsmasq_add_loop_detect branch August 26, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add --dns-loop-detect option to dnsmasq run by kube-dns
8 participants