Automated cherry pick of #67097: Ignore EIO error in unmount path #67443
Conversation
|
@chakri-nelluri: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #67097. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chakri-nelluri: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/M
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
the
cncf-cla: yes
|
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
|
||
| notmnt, err := isNotMounted(d.plugin.host.GetMounter(d.plugin.GetPluginName()), deviceMountPath) | ||
| if err != nil { | ||
| return err | ||
| if util.IsCorruptedMnt(err) { | ||
| notmnt = false // Corrupted error is assumed to be mounted. |
There was a problem hiding this comment.
Just curious: not sure why is assumed to be mounted if the error can be ENOTCONN, for example
But this is identical to the original, so the same should be here in the cherry-pick :)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
MaciekPytel
added
cherry-pick-approved
|
Can you add release note to #67097? Ideally release notes for patch release should mention every non-trivial change in the release, so the users know what to expect when they upgrade. Release notes are generated from original PRs to master, not cherry-picks, so adding the note just to this PR won't make it show up in release notes. |
|
Also: I've approved cherry-pick, but this needs to be approved by an owner of pkg/volume/util today to make it to 1.10.7. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chakri-nelluri, gnufied, rata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Cherry pick of #67097 on release-1.10.
#67097: Ignore EIO error in unmount path