Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes json logging in fluentd-elasticsearch image #67544

Merged
merged 4 commits into from Aug 20, 2018

Conversation

Projects
None yet
5 participants
@monotek
Copy link
Member

commented Aug 17, 2018

What this PR does / why we need it:

  • fixes json logging in fluentd-elasticsearch image by downgrading fluent-plugin-kubernetes_metadata_filter plugin to version 2.0.0
  • adds missing pos files to fluentd config
  • adds mapping type name

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

fixes json logging in fluentd-elasticsearch image by downgrading fluent-plugin-kubernetes_metadata_filter plugin to version 2.0.0
@monotek

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2018

/assign @coffeepac

@@ -48,24 +48,24 @@ roleRef:
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: fluentd-es-v2.2.0
name: fluentd-es-v2..0

This comment has been minimized.

Copy link
@coffeepac

coffeepac Aug 17, 2018

Member

please correct the version number.

@coffeepac

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

@monotek can you split this into two PRs? one for updating the image and one for updating the template?

this lets us rev the image without breaking the build as we still need to get outside help to manage the image build process.

@coffeepac

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

/approve
/ok-to-test

monotek added some commits Aug 17, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Aug 17, 2018

@monotek

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2018

used image version 2.2.0 again.
adding new pr for the template when image is build.

@monotek

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2018

/retest

1 similar comment
@monotek

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Aug 20, 2018

@coffeepac

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 20, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2018

Automatic merge from submit-queue (batch tested with PRs 67593, 67544). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e9de06d into kubernetes:master Aug 20, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation monotek authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

/sig instrumentation
for the release note tool.

@monotek monotek referenced this pull request Dec 5, 2018

Closed

REQUEST: New membership for monotek #288

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.