Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CoreDNS as default for kube-up deployments #67569

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

fturib
Copy link

@fturib fturib commented Aug 19, 2018

What this PR does / why we need it:
Enable CoreDNS as default (for kube-up installations)
It will allow to run CI tests to prepare graduation criteria for CoreDNS as Default

see : KEP - https://github.com/kubernetes/community/blob/master/keps/sig-network/0012-20180518-coredns-default-proposal.md
see also : kubernetes/enhancements#566

NOTE for release : I guess that CoreDNS as default server for k8s needs a longer description. This specific PR is to ensure we validate all e2e.

Make CoreDNS be the default DNS server in kube-up (instead of kube-dns formerly). 
It is still possible to deploy kube-dns by setting CLUSTER_DNS_CORE_DNS=false.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 19, 2018
@fturib
Copy link
Author

fturib commented Aug 19, 2018

@rajansandeep : I spend long time to check the failing e2e tests for the other PR. And I guess there cases when the e2e pull-kubernetes-gce ends in cored dumped and then timeout.
That does not explain all the issue .. but I would like to test with another PR.

Could you set the flat "ok-to-test" ? Thanks!
related PR is here : #62147

And, for sure, the I cannot reproduce on similar deployment e2e on GCE ... :)
Here is what I get on test on a private test on GCE:

running:

cd $GOPATH/src/github.com/kubernetes/kubernetes
kubetest --dump=/tmp/whatever/_artifacts --gcp-service-account=/home/admin/k8s-coredns-integration-8b248dc238e6.json --up --test --provider=gce --gcp-node-image=gci --gcp-zone=us-central1-f --ginkgo-parallel=30 --runtime-config=batch/v2alpha1=true,admissionregistration.k8s.io/v1alpha1=true --timeout=65m --test_args="--ginkgo.skip=\\[Slow\\]|\\[Serial\\]|\\[Disruptive\\]|\\[Flaky\\]|\\[Feature:.+\\] --minStartupPods=8"

result:

Ran 486 of 1032 Specs in 1215.969 seconds
SUCCESS! -- 486 Passed | 0 Failed | 0 Pending | 546 Skipped 

@rajansandeep
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/apiserver area/code-generation area/custom-resources area/kubeadm sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 21, 2018
@fturib
Copy link
Author

fturib commented Aug 21, 2018

With consensus on the way to resolve this issue : kubernetes/dns#254

Adding port remapping to 10053.
That will avoid to deal with super-admin privileges and therefore with PodSecurityPolicies.
This mapping was the only point that needed privileges

@fturib
Copy link
Author

fturib commented Aug 21, 2018

/unlabel area/apiserver

@fturib
Copy link
Author

fturib commented Aug 21, 2018

I mad a mistaking in build the push ... and therefore for a few time had a lot of code. and the Bot added a lot of labels.
I change the commit and have now the correct change. However the labels are not going away ...

@rajansandeep : do you have a way to remove the unecessary labels : all "area/..", "sig/xx"
And then will add the "sig/network". ?

@thockin
Copy link
Member

thockin commented Aug 24, 2018

@kubernetes/sig-contributor-experience-bugs

Hey contribex folks - Am I not able to LGTM something without approving? I see those two statements as very orthogonal.

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. kind/bug Categorizes issue or PR as related to a bug. labels Aug 24, 2018
@dims
Copy link
Member

dims commented Aug 24, 2018

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 27, 2018
@fturib
Copy link
Author

fturib commented Aug 27, 2018

/test pull-kubernetes-e2e-kops-aws

@fturib
Copy link
Author

fturib commented Aug 27, 2018

/retest

1 similar comment
@fturib
Copy link
Author

fturib commented Aug 27, 2018

/retest

@fturib
Copy link
Author

fturib commented Aug 28, 2018

@thockin : this PR is ready.
It enables CoreDNS as the default DNS Service when Kubernetes is deplyed with Kube-up.

This PR does not depend to any release of CoreDNS and can be applied immediately

NOTE: I think it would be good to merge asap, so we can evaluate impact on ALL the e2e tests that uses kube-up to deploy a cluster for test.

I would not expect issue ... but who knows ?

@rajansandeep
Copy link
Contributor

@kubernetes/sig-network-pr-reviews @thockin
This PR requires the milestone tags and lgtm to merge.

@neolit123
Copy link
Member

/remove-kind bug
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 29, 2018
@justaugustus
Copy link
Member

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 29, 2018
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-gke

@thockin
Copy link
Member

thockin commented Aug 29, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fturib, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67745, 67432, 67569, 67825, 67943). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants