Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test cases for scheduler/algorithm/predicates. #67642

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Add unit test cases for scheduler/algorithm/predicates. #67642

merged 1 commit into from
Aug 27, 2018

Conversation

tizhou86
Copy link
Member

What this PR does / why we need it:
Add unit test cases for scheduler/algorithm/predicates for more code coverage.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
NONE

Special notes for your reviewer:
NONE

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Aug 21, 2018
neolit123
neolit123 reviewed Aug 21, 2018
View reviewed changes
pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
t.Run(test.name, func(t *testing.T) {
fits, reasons, err := CheckNodePIDPressurePredicate(test.pod, PredicateMetadata(test.pod, nil), test.nodeInfo)
if err != nil {
t.Errorf("unexpected error: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use t.Fatalf() here instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for the advice!

@neolit123
Copy link
Member

neolit123 commented Aug 21, 2018 •
edited
Loading

/remove-kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 21, 2018
k82cn
k82cn reviewed Aug 22, 2018
View reviewed changes
pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
Status: v1.NodeStatus{
Conditions: []v1.NodeCondition{
{
Type: "PIDPressure",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with const

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

k82cn
k82cn reviewed Aug 23, 2018
View reviewed changes
pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
Conditions: []v1.NodeCondition{
{
Type: v1.NodeReady,
Status: "True",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have const for status :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll fix it.

@tizhou86 tizhou86 force-pushed the newUnitTest7 branch 3 times, most recently from af38289 to ee38bbb Compare August 23, 2018 08:50
@resouer
Copy link
Contributor

resouer commented Aug 23, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2018
resouer
resouer reviewed Aug 24, 2018
View reviewed changes
pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
name string
}{
{
pod: pod,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you only defined one pod for this test. Then it does not need to be part of test case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised, thanks!

@tizhou86
Copy link
Member Author

/retest

@k82cn
Copy link
Member

k82cn commented Aug 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, tizhou86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67766, 67642, 67772). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f07d095 into kubernetes:master Aug 27, 2018
@tizhou86 tizhou86 mentioned this pull request Sep 3, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@resouer resouer resouer left review comments

@k82cn k82cn k82cn left review comments

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tizhou86 @neolit123 @resouer @k82cn @k8s-ci-robot @fejta-bot @k8s-github-robot