kube-apiserver: always create configmap/extension-apiserver-authentication #67694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Other components read the configmap and fail if it does not exist. Possibly not every cluster has a client-ca or a request-header-ca.
k8s-ci-robot
added
size/XS
sttts
added
release-note-none
sttts
changed the title
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
/retest rs flakes |
|
seems pretty reasonable to me |
|
/assign @cheftako |
k8s-ci-robot
added
release-note
|
/lgtm /hold holding to give @cheftako at least until next week if we wants it. |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
As discussed, unholding on Tuesday. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Automatic merge from submit-queue (batch tested with PRs 67694, 64973, 67902). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 30, 2018
…-apiserver-authn-configmap Automatic merge from submit-queue (batch tested with PRs 67764, 68034, 67836). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. apiserver: make not-found external-apiserver-authn configmap non-fatal As client-ca and requestheader-client-ca is optional in the external-apiserver-authentication config file and components like kube-controller-manager and kube-scheduler won't need that anyway, we better make it non-fatal if the configmap is not found in the cluster. Consumer counter-part PR to #67694. ```release-note Don't let aggregated apiservers fail to launch if the external-apiserver-authentication configmap is not found in the cluster. ```
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Aug 30, 2018
…-apiserver-authn-configmap Automatic merge from submit-queue (batch tested with PRs 67764, 68034, 67836). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. apiserver: make not-found external-apiserver-authn configmap non-fatal As client-ca and requestheader-client-ca is optional in the external-apiserver-authentication config file and components like kube-controller-manager and kube-scheduler won't need that anyway, we better make it non-fatal if the configmap is not found in the cluster. Consumer counter-part PR to kubernetes/kubernetes#67694. ```release-note Don't let aggregated apiservers fail to launch if the external-apiserver-authentication configmap is not found in the cluster. ``` Kubernetes-commit: 55859a60fe09c412e183c92ad265cf0d52fbe3d8
sttts
pushed a commit
to sttts/apiserver
that referenced
this pull request
Sep 5, 2018
…-apiserver-authn-configmap Automatic merge from submit-queue (batch tested with PRs 67764, 68034, 67836). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. apiserver: make not-found external-apiserver-authn configmap non-fatal As client-ca and requestheader-client-ca is optional in the external-apiserver-authentication config file and components like kube-controller-manager and kube-scheduler won't need that anyway, we better make it non-fatal if the configmap is not found in the cluster. Consumer counter-part PR to kubernetes/kubernetes#67694. ```release-note Don't let aggregated apiservers fail to launch if the external-apiserver-authentication configmap is not found in the cluster. ``` Kubernetes-commit: 55859a60fe09c412e183c92ad265cf0d52fbe3d8
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Sep 6, 2018
…-apiserver-authn-configmap Automatic merge from submit-queue (batch tested with PRs 67764, 68034, 67836). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. apiserver: make not-found external-apiserver-authn configmap non-fatal As client-ca and requestheader-client-ca is optional in the external-apiserver-authentication config file and components like kube-controller-manager and kube-scheduler won't need that anyway, we better make it non-fatal if the configmap is not found in the cluster. Consumer counter-part PR to kubernetes/kubernetes#67694. ```release-note Don't let aggregated apiservers fail to launch if the external-apiserver-authentication configmap is not found in the cluster. ``` Kubernetes-commit: 55859a60fe09c412e183c92ad265cf0d52fbe3d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other components (aggregated apiservers) read the configmap and fail hard if it does not exist. But they work without all fields being set (#66394). In the future, components like ctrl-manager and scheduler won't need kube-apiserver to authenticate with them at all. So, consequently we should always create the file, even if it is empty.