New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag `--no-headers` to `kubectl top ...` #67890

Merged
merged 1 commit into from Sep 26, 2018

Conversation

@WanLinghao
Contributor

WanLinghao commented Aug 27, 2018

What this PR does / why we need it:
add flag --no-headers to kubectl top ...
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67886

Special notes for your reviewer:

Release note:

kubectl: add the --no-headers flag to `kubectl top ...`
@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 27, 2018

Member

@WanLinghao

please add a release note:

kubectl: add the --no-headers flag to kubectl top

optionally also explain what it does.

Member

neolit123 commented Aug 27, 2018

@WanLinghao

please add a release note:

kubectl: add the --no-headers flag to kubectl top

optionally also explain what it does.

@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Aug 28, 2018

Contributor

@neolit123 Done PTAL

Contributor

WanLinghao commented Aug 28, 2018

@neolit123 Done PTAL

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 28, 2018

Member

thanks for the update. LGTM.
leaving the rest of review to the maintainers. 👍

Member

neolit123 commented Aug 28, 2018

thanks for the update. LGTM.
leaving the rest of review to the maintainers. 👍

@interma

In addition, I think it is better to add tests in top_node_test.go/top_pod_test.go.

Show outdated Hide outdated pkg/kubectl/metricsutil/metrics_printer.go Outdated
@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Aug 30, 2018

Contributor

@interma Done PTAL

Contributor

WanLinghao commented Aug 30, 2018

@interma Done PTAL

@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Aug 31, 2018

Contributor

/test pull-kubernetes-integration

Contributor

WanLinghao commented Aug 31, 2018

/test pull-kubernetes-integration

@interma

This comment has been minimized.

Show comment
Hide comment
@interma

interma Aug 31, 2018

Contributor

Thanks @WanLinghao
I am not a reviewer, +1 for my personal side.

Contributor

interma commented Aug 31, 2018

Thanks @WanLinghao
I am not a reviewer, +1 for my personal side.

@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Sep 5, 2018

Contributor

@liggitt PTAL

Contributor

WanLinghao commented Sep 5, 2018

@liggitt PTAL

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Sep 5, 2018

Member

/assign @soltysh

Member

liggitt commented Sep 5, 2018

/assign @soltysh

@soltysh

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 26, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 26, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, WanLinghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, WanLinghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Sep 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Sep 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Sep 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Sep 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 71186a6 into kubernetes:master Sep 26, 2018

18 of 19 checks passed

Submit Queue Milestone is for a future release and cannot be merged
Details
cla/linuxfoundation WanLinghao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment