Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag --no-headers to kubectl top ... #67890

Merged
merged 1 commit into from
Sep 26, 2018
Merged

add flag --no-headers to kubectl top ... #67890

merged 1 commit into from
Sep 26, 2018

Conversation

WanLinghao
Copy link
Contributor

@WanLinghao WanLinghao commented Aug 27, 2018 •
edited
Loading

What this PR does / why we need it:
add flag --no-headers to kubectl top ...
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67886

Special notes for your reviewer:

Release note:

kubectl: add the --no-headers flag to `kubectl top ...`

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2018
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Aug 27, 2018
@neolit123
Copy link
Member

@WanLinghao

please add a release note:

kubectl: add the --no-headers flag to kubectl top

optionally also explain what it does.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 28, 2018
@WanLinghao
Copy link
Contributor Author

@neolit123 Done PTAL

@neolit123
Copy link
Member

thanks for the update. LGTM.
leaving the rest of review to the maintainers. 👍

interma
interma reviewed Aug 28, 2018
View reviewed changes
Copy link
Contributor

@interma interma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, I think it is better to add tests in top_node_test.go/top_pod_test.go.

pkg/kubectl/metricsutil/metrics_printer.go Outdated
@@ -53,7 +53,7 @@ func NewTopCmdPrinter(out io.Writer) *TopCmdPrinter {
return &TopCmdPrinter{out: out}
}

func (printer *TopCmdPrinter) PrintNodeMetrics(metrics []metricsapi.NodeMetrics, availableResources map[string]v1.ResourceList) error {
func (printer *TopCmdPrinter) PrintNodeMetrics(metrics []metricsapi.NodeMetrics, availableResources map[string]v1.ResourceList, NoHeaders bool) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style: noHeaders?

@WanLinghao
Copy link
Contributor Author

@interma Done PTAL

@WanLinghao
Copy link
Contributor Author

/test pull-kubernetes-integration

@interma
Copy link
Contributor

interma commented Aug 31, 2018

Thanks @WanLinghao
I am not a reviewer, +1 for my personal side.

@WanLinghao
Copy link
Contributor Author

@liggitt PTAL

@liggitt
Copy link
Member

liggitt commented Sep 5, 2018

/assign @soltysh

soltysh
soltysh approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, WanLinghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 71186a6 into kubernetes:master Sep 26, 2018
@interma interma mentioned this pull request Dec 12, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@interma interma interma left review comments

@soltysh soltysh soltysh approved these changes

@marceloboeira marceloboeira marceloboeira approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak

@ericchiang ericchiang Awaiting requested review from ericchiang

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flag --no-headers to kubectl top ...
8 participants
@WanLinghao @neolit123 @interma @liggitt @k8s-ci-robot @fejta-bot @soltysh @marceloboeira