Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest and version for CoreDNS #68076

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Update manifest and version for CoreDNS #68076

merged 1 commit into from
Aug 31, 2018

Conversation

rajansandeep
Copy link
Contributor

What this PR does / why we need it:
Updates the manifest of CoreDNS and also bumps the version of CoreDNS to 1.2.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68020

Special notes for your reviewer:

Release note:

CoreDNS is now v1.2.2 for Kubernetes 1.12

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 30, 2018
@rajansandeep
Copy link
Contributor Author

/cc @timothysc @MrHohn
/assign @thockin

@rajansandeep
Copy link
Contributor Author

fyi @fturib @chrisohaver

@MrHohn
Copy link
Member

MrHohn commented Aug 30, 2018

Just to confirm, so this is pending on k8s.gcr.io/coredns:1.2.2 being pushed?

@rajansandeep
Copy link
Contributor Author

@MrHohn The image has already been pushed and is available.

MrHohn
MrHohn approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
thockin
thockin reviewed Aug 30, 2018
View reviewed changes
cmd/kubeadm/app/phases/addons/dns/dns.go
@@ -310,6 +310,7 @@ func translateStubDomainOfKubeDNSToProxyCoreDNS(dataField string, kubeDNSConfigM
pStanza["body"] = [][]string{
{"errors"},
{"cache", "30"},
{"loop"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no loadbalance here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That bit is for creating stub domain stanzas, so coredns is just forwarding here. I was thinking we would not want to randomize answers from stubdomains, since those servers may already be deliberately ordering the answers.

@thockin
Copy link
Member

thockin commented Aug 30, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
timothysc
timothysc approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve from my side.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, rajansandeep, thockin, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Aug 31, 2018

release note clearly indicates that this is for 1.12

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 31, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67756, 64149, 68076, 68131, 68120). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 36187c6 into kubernetes:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@chrisohaver chrisohaver chrisohaver left review comments

@timothysc timothysc timothysc approved these changes

@MrHohn MrHohn MrHohn approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@thockin thockin

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Push the CoreDNS 1.2.2 image in gcr.io
8 participants
@rajansandeep @MrHohn @thockin @k8s-ci-robot @dims @k8s-github-robot @timothysc @chrisohaver