Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark HPA REST Clients Flag as Deprecated #68089

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Mark HPA REST Clients Flag as Deprecated #68089

merged 1 commit into from
Sep 4, 2018

Conversation

DirectXMan12
Copy link
Contributor

This marks the option to switch to Heapster for the HPA as deprecated.
It'll be removed next release when Heapster is retired.

Release note:

Using the Horizontal Pod Autoscaler with metrics from Heapster is now deprecated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2018
@DirectXMan12
Copy link
Contributor Author

cc @kubernetes/sig-autoscaling-pr-reviews

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 30, 2018
@DirectXMan12
Copy link
Contributor Author

I realized that despite talking about and announcing this, we hand officially marked it in the code. This fixes that omission.

@fedebongio
Copy link
Contributor

/cc @wenjiaswe thanks!

@MaciekPytel
Copy link
Contributor

Nice catch!
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 31, 2018
@DirectXMan12
Mark HPA REST Clients Flag as Deprecated
ec428d2 
This marks the option to switch to Heapster for the HPA as deprecated.
It'll be removed next release when Heapster is retired.
@DirectXMan12 DirectXMan12 force-pushed the feature/hpa-heapster-deprecation branch from 0ef8281 to ec428d2 Compare September 3, 2018 05:43
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 3, 2018
@DirectXMan12
Copy link
Contributor Author

rebased. someone with appropriate powers that's not offline monday, PTAL.

@DirectXMan12
Copy link
Contributor Author

@deads2k or someone else, PTAL

@deads2k
Copy link
Contributor

deads2k commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, DirectXMan12, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 4743489 into kubernetes:master Sep 4, 2018
@DirectXMan12 DirectXMan12 deleted the feature/hpa-heapster-deprecation branch September 4, 2018 18:53
@serathius serathius mentioned this pull request Feb 25, 2020
Closed
@serathius serathius mentioned this pull request Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j3ffml j3ffml Awaiting requested review from j3ffml

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@MaciekPytel MaciekPytel

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DirectXMan12 @fedebongio @MaciekPytel @deads2k @k8s-ci-robot @k8s-github-robot