New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark HPA REST Clients Flag as Deprecated #68089

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@DirectXMan12
Contributor

DirectXMan12 commented Aug 30, 2018

This marks the option to switch to Heapster for the HPA as deprecated.
It'll be removed next release when Heapster is retired.

Release note:

Using the Horizontal Pod Autoscaler with metrics from Heapster is now deprecated.
@DirectXMan12

This comment has been minimized.

Show comment
Hide comment
@DirectXMan12
Contributor

DirectXMan12 commented Aug 30, 2018

@DirectXMan12

This comment has been minimized.

Show comment
Hide comment
@DirectXMan12

DirectXMan12 Aug 30, 2018

Contributor

I realized that despite talking about and announcing this, we hand officially marked it in the code. This fixes that omission.

Contributor

DirectXMan12 commented Aug 30, 2018

I realized that despite talking about and announcing this, we hand officially marked it in the code. This fixes that omission.

@fedebongio

This comment has been minimized.

Show comment
Hide comment
@fedebongio

fedebongio commented Aug 30, 2018

/cc @wenjiaswe thanks!

@MaciekPytel

This comment has been minimized.

Show comment
Hide comment
@MaciekPytel

MaciekPytel Aug 31, 2018

Contributor

Nice catch!
/lgtm

Contributor

MaciekPytel commented Aug 31, 2018

Nice catch!
/lgtm

Mark HPA REST Clients Flag as Deprecated
This marks the option to switch to Heapster for the HPA as deprecated.
It'll be removed next release when Heapster is retired.
@DirectXMan12

This comment has been minimized.

Show comment
Hide comment
@DirectXMan12

DirectXMan12 Sep 3, 2018

Contributor

rebased. someone with appropriate powers that's not offline monday, PTAL.

Contributor

DirectXMan12 commented Sep 3, 2018

rebased. someone with appropriate powers that's not offline monday, PTAL.

@DirectXMan12

This comment has been minimized.

Show comment
Hide comment
@DirectXMan12

DirectXMan12 Sep 4, 2018

Contributor

@deads2k or someone else, PTAL

Contributor

DirectXMan12 commented Sep 4, 2018

@deads2k or someone else, PTAL

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 4, 2018

Contributor

/lgtm

Contributor

deads2k commented Sep 4, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 4, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, DirectXMan12, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, DirectXMan12, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 4, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Contributor

k8s-merge-robot commented Sep 4, 2018

Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-merge-robot k8s-merge-robot merged commit 4743489 into kubernetes:master Sep 4, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation DirectXMan12 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@DirectXMan12 DirectXMan12 deleted the DirectXMan12:feature/hpa-heapster-deprecation branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment