Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable shell test for non-gce providers #6817

Merged
merged 1 commit into from
Apr 15, 2015
Merged

Disable shell test for non-gce providers #6817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/e2e/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ var (
var _ = Describe("Shell", func() {

defer GinkgoRecover()

// A number of scripts only work on gce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add gke as well? This works on gke as well as gce since both support gcloud compute ssh for the ssh-to-node function (although it isn't currently passing - we should look into that).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

if testContext.Provider != "gce" && testContext.Provider != "gke" {
By(fmt.Sprintf("Skipping Shell test, which is only supported for provider gce and gke (not %s)",
testContext.Provider))
return
}

// Slurp up all the tests in hack/e2e-suite
bashE2ERoot := filepath.Join(root, "hack/e2e-suite")
files, err := ioutil.ReadDir(bashE2ERoot)
Expand Down