New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mount propagation feature gate #68230

Merged
merged 1 commit into from Nov 2, 2018

Conversation

@bertinatto
Member

bertinatto commented Sep 4, 2018

What this PR does / why we need it:

This PR removes the logic around the mount propagation feature gate deprecated in v1.12. It's a follow-up to #67255.

Release note:

The `MountPropagation` feature is unconditionally enabled in v1.13, and can no longer be disabled.
@bertinatto

This comment has been minimized.

Member

bertinatto commented Sep 4, 2018

/sig storage
/assign jsafrane

@bertinatto

This comment has been minimized.

Member

bertinatto commented Sep 4, 2018

/hold

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 2, 2018

/hold cancel

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 2, 2018

/assign @liggitt

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 3, 2018

/ok-to-test
/lgtm

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 3, 2018

/retest

3 similar comments
@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 3, 2018

/retest

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 3, 2018

/retest

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 4, 2018

/retest

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 4, 2018

/test pull-kubernetes-local-e2e-containerized

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 4, 2018

/retest

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 8, 2018

There's a failing test (pull-kubernetes-local-e2e-containerized) preventing this PR from being merged.

#69465 needs to be fixed first.

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 9, 2018

/retest

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 10, 2018

@liggitt, could you take another look, please? I had forgotten to include the changes in pkg/kubelet/kubelet_pods_linux_test.go, so I lost the lgtm label.

Also,

/assign @tallclair

for changes in Kubelet.

@tallclair

This comment has been minimized.

Member

tallclair commented Oct 10, 2018

See kubernetes/website#10294

Looks like the current policy is that the feature gate must continue to function for at least 2 releases after GA, but can be a no-op (i.e. you can remove the logic, but need to keep the gate until 1.14).

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 25, 2018

@tallclair, I updated the PR to keep the gate and remove the logic. Please let me know if I'm missing something.

@tallclair

This comment has been minimized.

Member

tallclair commented Oct 29, 2018

/lgtm
If you're up for it, can you also update the warning here and the comment here to specify which release the feature gate will be removed in (I think 1.14 according to the latest iteration of the policy).

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 29, 2018

@tallclair

This comment has been minimized.

Member

tallclair commented Oct 29, 2018

Please update the release note too.

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 30, 2018

I think that warning should be escalated to an error if they attempt to disable the feature, now that disabling it has no effect. Agree on updating comments to indicate removal in 1.14.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 30, 2018

@bertinatto

This comment has been minimized.

Member

bertinatto commented Oct 31, 2018

@tallclair, @liggitt: thanks, updated PR.

Show resolved Hide resolved pkg/kubelet/kubelet.go Outdated
@liggitt

This comment has been minimized.

Member

liggitt commented Oct 31, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 31, 2018

/approve

@tallclair

This comment has been minimized.

Member

tallclair commented Nov 1, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented Nov 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented Nov 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 08351b6 into kubernetes:master Nov 2, 2018

18 checks passed

cla/linuxfoundation bertinatto authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment