Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #67224: Add namespace for (cluster)role(binding) cloud-provider. #68259

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Automated cherry pick of #67224: Add namespace for (cluster)role(binding) cloud-provider. #68259

merged 1 commit into from
Oct 4, 2018

Conversation

grayluck
Copy link
Contributor

@grayluck grayluck commented Sep 5, 2018

Cherry pick of #67224 on release-1.11.

#67224: Add namespace for (cluster)role(binding) cloud-provider.

@grayluck
Add namespace for (cluster)role(binding) cloud-provider.
7bc399d 
Change the addonmanager mode to be from reconcile to EnsureExists.
@k8s-ci-robot
Copy link
Contributor

@grayluck:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2018
@neolit123
Copy link
Member

/sig auth
/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2018
@grayluck
Copy link
Contributor Author

grayluck commented Sep 5, 2018

Manual test:

$ kk auth can-i list configmaps --as=system:serviceaccount:kube-system:cloud-provider
yes
$ kk auth can-i create events --as=system:serviceaccount:kube-system:cloud-provider  
yes

/assign @bowei
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 5, 2018
@grayluck
Copy link
Contributor Author

grayluck commented Sep 5, 2018

/retest

1 similar comment
@grayluck
Copy link
Contributor Author

grayluck commented Sep 5, 2018

/retest

@nikhita nikhita mentioned this pull request Sep 5, 2018
Merged
@bowei
Copy link
Member

bowei commented Sep 10, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, grayluck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@grayluck
Copy link
Contributor Author

/assign @foxish
For milestone 1.11 and cherrypick approval.

@grayluck
Copy link
Contributor Author

/assign @calebamiles

@grayluck
Copy link
Contributor Author

Friendly ping.
/assign @nikhita

@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

/unassign

@foxish is the cherry-pick approved?

@foxish foxish added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 3, 2018
@foxish foxish removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 3, 2018
@foxish foxish added this to the v1.11 milestone Oct 3, 2018
@foxish foxish added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 3, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0d7846c into kubernetes:release-1.11 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@bowei bowei

@calebamiles calebamiles

@foxish foxish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@grayluck @k8s-ci-robot @neolit123 @bowei @nikhita @fejta-bot @calebamiles @foxish